Page MenuHomePhabricator

Update Jade for changes in AbuseFilter and SpamBlacklist API error responses
Closed, ResolvedPublic

Description

API error responses generated by AbuseFilter and SpamBlacklist have changed, as announced here: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2019-September/000148.html (relevant task: T229539).

It appears you have special handling for the old responses. This only affects unit tests (so they are probably failing now):

extensions/Jade/tests/phpunit/AbuseFilter/AbuseFilterTest.php:
   73: 			'action' => 'abusefiltercheckmatch',
   78: 		$this->assertTrue( $result[0]['abusefiltercheckmatch']['result'] );

extensions/Jade/tests/phpunit/SpamBlacklist/SpamBlacklistTest.php:
   87: 			'spamblacklist' => 'unusual-stringy',

Details

Related Gerrit Patches:
mediawiki/extensions/Jade : masterFix failing unit tests

Event Timeline

Change 540926 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Jade@master] Fix failing unit tests

https://gerrit.wikimedia.org/r/540926

Change 540926 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Fix failing unit tests

https://gerrit.wikimedia.org/r/540926

matmarex closed this task as Resolved.Oct 17 2019, 3:50 PM
matmarex assigned this task to Umherirrender.