Page MenuHomePhabricator

WWT: Make the links functional again if there is an API error [small]
Closed, ResolvedPublic

Description

As a WWT user, I want links in the page to be functional after an API error, so that WWT-related errors do not hinder or confuse my general user experience.

Acceptance Criteria:

  • If the user experiences an API error in WWT, the links should be made functional again
  • If possible, keep the links functional like normal even while it is loading.

Visual Example:

Screenshot 2019-10-05 at 5.36.52 PM.png (576×1 px, 262 KB)
WWT API has failed, links are un-clickable till I disable the tool

Event Timeline

ifried renamed this task from Make the links functional again if there is an API error in WWT to WWT: Make the links functional again if there is an API error.Oct 29 2019, 5:29 PM
ifried updated the task description. (Show Details)

@Prtksxna Can you provide more context around this recommended behavior? In other words, what are the main reasons why you would like this behavior to occur? Thanks!

When the WWT has failed to load it cant show the WWT popups. The reason we disable the links when WWT is active is because clicking them should open the WWT popup, if that is not the case, we shouldn't be disabling the links.

ifried renamed this task from WWT: Make the links functional again if there is an API error to WWT: Make the links functional again if there is an API error [small].Nov 28 2019, 12:56 AM

@Prtksxna code-wise, this should already be happening; we're only disabling links in the html we're getting from WhoColor -- and if there's an API error we aren't getting that and are not replacing anything.

So I was worried we've missed something so I forced API errors in a couple of pages to make sure -- and I couldn't get this to fail. It works for me -- if there's an API error, the links still work for me. The links are also clickable for me while the blue-bar is loading.

Is this still happening for you? If so, can you provide the link/article to where, or some details about maybe what preceeded this (was it previously loaded and then reloaded? is it in the content of the article or some template maybe? etc) because I can't manage to reproduce this.

I didn't know how to force an API error so I switched off the Wifi to get a generic error, is that the same?

At the moment I am not able to re-produce this either. Closing for now.

I didn't know how to force an API error so I switched off the Wifi to get a generic error, is that the same?

At the moment I am not able to re-produce this either. Closing for now.

Yup, that would do it, so if you didn't see it, it should be representative. If you encounter this again, we'll reopen.