Page MenuHomePhabricator
Create Task
Maniphest T236260

Basic cleanup of PHP code in preparation for refined <ref>s
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Basic cleanup of the existing PHP code, apply current best practices. There is a lot of very ugly code, esp. callbacks like [ $obj, 'method' ], as well as a dynamically created attribute stuffed in the Parser! At least make sure each issue is local, in as few places as possible.

Limit scope of cleanup to the code we probably need to touch.

Original estimation: 8

Details

SubjectRepoBranchLines +/-
Move unrelated static code to ApiQueryReferencesmediawiki/extensions/Citemaster+89 -86
Move misplaced ParserFirstCallInit hook handler to CiteHooksmediawiki/extensions/Citemaster+32 -31
Make use of PHP7's ?? feature instead of isset()mediawiki/extensions/Citemaster+6 -18
Streamline Hooks section in extension.jsonmediawiki/extensions/Citemaster+7 -21
Simplify private listToText() implementationmediawiki/extensions/Citemaster+5 -6
Make use of ctype_digit() instead of a regexmediawiki/extensions/Citemaster+1 -3
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Oct 23 2019, 1:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2019, 1:05 PM
thiemowmde set the point value for this task to 8.Oct 24 2019, 7:17 AM
JStrodt_WMDE moved this task from Backlog to Tickets in sprint on the Cite-Extends board.Oct 24 2019, 8:19 AM
gerritbot added a comment.Oct 25 2019, 8:13 AM

Change 546104 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Make use of ctype_digit() instead of a regex

https://gerrit.wikimedia.org/r/546104

gerritbot added a project: Patch-For-Review.Oct 25 2019, 8:13 AM
gerritbot added a comment.Oct 25 2019, 8:18 AM

Change 546106 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Simplify private listToText() implementation

https://gerrit.wikimedia.org/r/546106

gerritbot added a comment.Oct 25 2019, 8:20 AM

Change 546107 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Make use of PHP7's ?? feature instead of isset()

https://gerrit.wikimedia.org/r/546107

gerritbot added a comment.Oct 25 2019, 8:28 AM

Change 546104 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Make use of ctype_digit() instead of a regex

https://gerrit.wikimedia.org/r/546104

gerritbot added a comment.Oct 25 2019, 8:29 AM

Change 546108 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Streamline Hooks section in extension.json

https://gerrit.wikimedia.org/r/546108

thiemowmde mentioned this in rECITb65e1bb2385f: Make use of ctype_digit() instead of a regex.Oct 25 2019, 8:31 AM
gerritbot added a comment.Oct 25 2019, 8:32 AM

Change 546106 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Simplify private listToText() implementation

https://gerrit.wikimedia.org/r/546106

thiemowmde mentioned this in rECIT7f99a1bfe149: Simplify private listToText() implementation.Oct 25 2019, 8:33 AM
gerritbot added a comment.Oct 25 2019, 8:38 AM

Change 546110 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Move misplaced ParserFirstCallInit hook handler to CiteHooks

https://gerrit.wikimedia.org/r/546110

gerritbot added a comment.Oct 25 2019, 8:52 AM

Change 546108 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Streamline Hooks section in extension.json

https://gerrit.wikimedia.org/r/546108

gerritbot added a comment.Oct 25 2019, 8:52 AM

Change 546107 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Make use of PHP7's ?? feature instead of isset()

https://gerrit.wikimedia.org/r/546107

gerritbot added a comment.Oct 25 2019, 8:54 AM

Change 546119 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Move unrelated static code to ApiQueryReferences

https://gerrit.wikimedia.org/r/546119

thiemowmde mentioned this in rECITa037f763179d: Streamline Hooks section in extension.json.Oct 25 2019, 8:55 AM
thiemowmde mentioned this in rECITddafb6adee76: Make use of PHP7's ?? feature instead of isset().
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 25 2019, 9:00 AM
gerritbot added a comment.Oct 25 2019, 9:02 AM

Change 546110 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Move misplaced ParserFirstCallInit hook handler to CiteHooks

https://gerrit.wikimedia.org/r/546110

thiemowmde mentioned this in rECIT28dd373d249d: Move misplaced ParserFirstCallInit hook handler to CiteHooks.Oct 25 2019, 9:03 AM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-10-23 board.Oct 25 2019, 10:54 AM
gerritbot added a comment.Oct 25 2019, 1:01 PM

Change 546119 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Move unrelated static code to ApiQueryReferences

https://gerrit.wikimedia.org/r/546119

thiemowmde mentioned this in rECITed8dee9bfe04: Move unrelated static code to ApiQueryReferences.Oct 25 2019, 1:03 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 25 2019, 1:10 PM
thiemowmde moved this task from Review to Done on the WMDE-QWERTY-Sprint-2019-10-23 board.Oct 30 2019, 10:56 AM
thiemowmde closed this task as Resolved.Oct 30 2019, 11:29 AM
thiemowmde claimed this task.

Further refactoring will be done as part of specific Cite-Extends tickets.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits