Page MenuHomePhabricator
Create Task
Maniphest T236742

🎬 desktop-de-08 | Prepare Banner B19_WMDE_08_laika – ⏰ 04.11.
Closed, ResolvedPublic
Actions

Description

Preview: B19_WMDE_08_ctrl

For testing the new compact Laika layout we will use identical CTRL and VAR banners that should be based on B19_WMDE_04_laika with error messages implemented since B19_WMDE_05_ctrl

Screenshot 2019-10-28 at 22.08.44.png (892×1 px, 149 KB)

Screenshot 2019-10-28 at 22.08.56.png (430×2 px, 161 KB)

Acceptance criteria

  • The base banner should be B19_WMDE_04_laika
  • It is acceptable that the banner gets bigger if the error messages is being displayed
  • Error messages should be displayed like in B19_WMDE_05_ctrl, i.e. styling, icons and actual messaging
  • Error messages should be left aligned inside its respective section (unlike B19_WMDE_05_ctrl where they are centered)

Related Objects
Search...

Event Timeline

• chrp created this task.Oct 28 2019, 8:58 PM
• chrp added subscribers: tmletzko, Jan_Dittrich.Oct 28 2019, 9:03 PM

@tmletzko The devs asked me to make this a separate ticket. The banner is basically a new banner although it is based on existing code. Please check the acceptance criteria, this is a suggestion from my side. Garbriel needed us to be more specific, especially regarding the what to copy from B19_WMDE_05_ctrl. Do we just want the style or also the changed errors messages. Should the icons in front of the errors message also be shown? Please change.

@gabriel-wmde This is the separate ticket.

@Jan_Dittrich FYI, there is a separate banner. Maybe Gabriel needs support with the style as the height of B19_WMDE_04_laika does not have enough room for the bigger error messages from B19_WMDE_05_ctrl but I guess to fix that you could approach him directly.

• chrp renamed this task from B19_WMDE_04_laika_new_form_errors to B19_WMDE_08_laika.Oct 28 2019, 9:04 PM
• chrp added a subtask: T236667: 🎬 desktop-de-08 | Make Laika adress form design more compact –⏰ 04.11..
• chrp added a comment.Oct 28 2019, 9:07 PM

B19_WMDE_08_laika is what I think this banner should be named, please update if that does not fit the naming convention.

• chrp updated the task description. (Show Details)Oct 28 2019, 9:11 PM
tmletzko updated the task description. (Show Details)Oct 29 2019, 6:54 AM
tmletzko added a comment.EditedOct 29 2019, 7:08 AM

three remarks

  • it is ok that the banner gets bigger if the error messages is being displayed
  • the error messages seem to be centered underneath the respective section. I rather have them left aligned.
  • I have no opinion about the banner name but for the campaign the banner should be name according to the current banner syntax.
• chrp updated the task description. (Show Details)Oct 29 2019, 7:48 AM

I've added your remarks into the acceptance criteria. Anything else from your side? Otherwise this ticket is ready for development.

• chrp added a comment.Oct 29 2019, 7:49 AM

@gabriel-wmde Is there anything potentially missing that you'd need?

• Tim_WMDE moved this task from Heap to Doing on the WMDE-FUN-Funban-2019 board.Oct 29 2019, 10:45 AM
• Tim_WMDE subscribed.Oct 29 2019, 10:56 AM

@tmletzko The screenshots in the ticket do not match the design of the banner you have linked (B19_WMDE_04_laika). Which one is the design you want?

• Tim_WMDE added a comment.Oct 29 2019, 10:58 AM

@tmletzko Okay, nevermind, I get it now: You just showed error message screenshots from banner 05 but you want that in the design from 04 which is not on the screenshots.

• Tim_WMDE moved this task from Doing to Code Review on the WMDE-FUN-Funban-2019 board.Oct 29 2019, 1:33 PM
• chrp assigned this task to tmletzko.Oct 31 2019, 1:20 PM
• chrp updated the task description. (Show Details)
• chrp updated the task description. (Show Details)
tmletzko reassigned this task from tmletzko to JanJaquemot.Oct 31 2019, 5:26 PM
JanJaquemot reassigned this task from JanJaquemot to • Tim_WMDE.Nov 1 2019, 10:12 AM
JanJaquemot subscribed.

Banner and error messages are looking good now. left aligned and everything.
Errors just slightly change the banner size in vertical mode which is fine.
However I saw that the "Weiter, um Spende abzuschliesen" button doesn't actually link through to the LP (well it doesn't work at all).
Please fix.

• Tim_WMDE removed • Tim_WMDE as the assignee of this task.Nov 3 2019, 11:44 AM
• chrp renamed this task from B19_WMDE_08_laika to 🎬 desktop-de-08 | Prepare Banner B19_WMDE_08_laika – ⏰ 10.11. .Nov 4 2019, 1:07 PM
• chrp renamed this task from 🎬 desktop-de-08 | Prepare Banner B19_WMDE_08_laika – ⏰ 10.11. to 🎬 desktop-de-08 | Prepare Banner B19_WMDE_08_laika – ⏰ 5.11. .
• chrp renamed this task from 🎬 desktop-de-08 | Prepare Banner B19_WMDE_08_laika – ⏰ 5.11. to 🎬 desktop-de-08 | Prepare Banner B19_WMDE_08_laika – ⏰ 04.11. .
• chrp moved this task from Code Review to Heap on the WMDE-FUN-Funban-2019 board.Nov 4 2019, 2:15 PM
gabriel-wmde added a comment.Nov 5 2019, 8:39 AM

@JanJaquemot You can preview the compact design at http://test-spenden-2.wikimedia.de/?skin=0&compact=1&zahlweise=BEZ&betrag=20
If you want to compare side-by-side in 2 windows, here is the URL for the "classic" version: You can preview the compact design at http://test-spenden-2.wikimedia.de/?skin=0&compact=0&zahlweise=BEZ&betrag=20

If the design is ok, I'll put in on the production server.

• chrp moved this task from Heap to Done on the WMDE-FUN-Funban-2019 board.Nov 7 2019, 11:09 AM
• chrp closed this task as Resolved.Nov 7 2019, 1:33 PM
• chrp closed subtask T236667: 🎬 desktop-de-08 | Make Laika adress form design more compact –⏰ 04.11. as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits