Page MenuHomePhabricator

maintain views has to run or has to be updated to fix errors on globalblocks and protected_titles for wikireplicas
Closed, ResolvedPublic

Description

From T236015:

Error    : Table 'ptwikimedia.globalblocks' doesn't exist
Error    : View 'ptwikimedia_p.globalblocks' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
Error    : Table 'pswikivoyage.globalblocks' doesn't exist
Error    : View 'pswikivoyage_p.globalblocks' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
Error    : Table 'pmswikisource.globalblocks' doesn't exist
Error    : View 'pmswikisource_p.globalblocks' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
Error    : Table 'plwikivoyage.globalblocks' doesn't exist
Error    : View 'plwikivoyage_p.globalblocks' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
...

And

ruwiki_p.protected_titles
Error    : Unknown column 'ruwiki.protected_titles.pt_reason' in 'field list'
Error    : View 'ruwiki_p.protected_titles' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them

The last one seems to be due to ongoing https://gerrit.wikimedia.org/r/c/mediawiki/core/+/482371/3/maintenance/archives/patch-drop-comment-fields.sql (T233135), so probably the view should skip that column everywhere.

The first shouldn't exist anywhere, except on centralauth (T230055), it may require some changes on the view creation/and or removal.

Details

Related Gerrit Patches:
operations/puppet : productionDepool labsdb1011
operations/puppet : productionDepool labsdb1010
operations/puppet : productionRemove 'globalblocks' table from maintain-views
operations/puppet : productionRevert "Depool labsdb1011"
operations/puppet : productionDepool labsdb1011
operations/puppet : productionRevert "Depool labsdb1010"
operations/puppet : productionDepool labsdb1010
operations/puppet : productionRevert "Depool labsdb1009"
operations/puppet : productionDepool labsdb1009

Event Timeline

jcrespo created this task.Wed, Nov 6, 10:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Nov 6, 10:39 AM
Reedy renamed this task from maintain views has to run or has to be updated to fix errors on globalocks and protected_titles for wikireplicas to maintain views has to run or has to be updated to fix errors on globalblocks and protected_titles for wikireplicas.Wed, Nov 6, 4:07 PM
Bstorm triaged this task as High priority.Wed, Nov 6, 4:38 PM
Bstorm moved this task from Backlog to Wiki replicas on the Data-Services board.
Bstorm moved this task from Inbox to Clinic Duty on the cloud-services-team (Kanban) board.
Bstorm added a comment.Fri, Nov 8, 8:40 PM

I think that the globalblocks part of this can be cleaned up with re-runs with the --clean option. The pt_reason error surprises me, but there could have been a miss there.
@jcrespo was that pt_reason error only on ruwiki_p or across most/all of them?

Andrew claimed this task.Fri, Nov 8, 8:50 PM
Andrew added a subscriber: Andrew.

Brooke says: "Its likely just running against all-databases with the --clean option" but we'll want to depool each DB server beforehand

@jcrespo was that pt_reason error only on ruwiki_p or across most/all of them?

Please see the linked task with the schema change- I believe it will eventually fail on all databases.

@jcrespo was that pt_reason error only on ruwiki_p or across most/all of them?

Please see the linked task with the schema change- I believe it will eventually fail on all databases.

Yeah, the ruwiki_p.protected_titles error is due to the schema change. I try to run the maintainviews everytime I finish a section to avoid it, but I probably missed that one when I finished s6.

Change 550878 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Depool labsdb1009

https://gerrit.wikimedia.org/r/550878

Change 550879 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Revert "Depool labsdb1009"

https://gerrit.wikimedia.org/r/550879

Change 550880 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Depool labsdb1010

https://gerrit.wikimedia.org/r/550880

Change 550881 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Revert "Depool labsdb1010"

https://gerrit.wikimedia.org/r/550881

Change 550882 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Depool labsdb1011

https://gerrit.wikimedia.org/r/550882

Change 550883 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Revert "Depool labsdb1011"

https://gerrit.wikimedia.org/r/550883

Change 550888 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Remove 'globalblocks' table from maintain-views

https://gerrit.wikimedia.org/r/550888

I have fixed across all the labsdb hosts (1009, 1010, 1011, 1012) the following view:

ruwiki_p.protected_titles

Change 550888 merged by Andrew Bogott:
[operations/puppet@production] Remove 'globalblocks' table from maintain-views

https://gerrit.wikimedia.org/r/550888

Change 550878 merged by Andrew Bogott:
[operations/puppet@production] Depool labsdb1009

https://gerrit.wikimedia.org/r/550878

Change 550879 merged by Andrew Bogott:
[operations/puppet@production] Revert "Depool labsdb1009"

https://gerrit.wikimedia.org/r/550879

Change 550880 merged by Andrew Bogott:
[operations/puppet@production] Depool labsdb1010

https://gerrit.wikimedia.org/r/550880

Change 550881 merged by Andrew Bogott:
[operations/puppet@production] Revert "Depool labsdb1010"

https://gerrit.wikimedia.org/r/550881

Change 550882 merged by Andrew Bogott:
[operations/puppet@production] Depool labsdb1011

https://gerrit.wikimedia.org/r/550882

Change 550883 merged by Andrew Bogott:
[operations/puppet@production] Revert "Depool labsdb1011"

https://gerrit.wikimedia.org/r/550883

Mentioned in SAL (#wikimedia-cloud) [2019-11-15T20:04:43Z] <andrewbogott> repool labdb1011 (T237509)

Andrew closed this task as Resolved.Fri, Nov 15, 8:08 PM

ran maintain-views --all-databases --replace-all —clean on labsdb1009, 1010, 1011, 1012.

This made the centralauth_p.globalblocks table unavalaible. There's now no globalblocks table avalaible anywhere. Please see T238480. Thank you.

Mentioned in SAL (#wikimedia-cloud) [2019-11-18T16:54:53Z] <andrewbogott> running maintain-views --all-databases --replace-all —clean on labsdb1012 T237509

Change 551577 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Depool labsdb1009

https://gerrit.wikimedia.org/r/551577

Change 551580 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Depool labsdb1010

https://gerrit.wikimedia.org/r/551580

Change 551583 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Depool labsdb1011

https://gerrit.wikimedia.org/r/551583

Change 551580 merged by Andrew Bogott:
[operations/puppet@production] Depool labsdb1010

https://gerrit.wikimedia.org/r/551580

Change 551583 merged by Andrew Bogott:
[operations/puppet@production] Depool labsdb1011

https://gerrit.wikimedia.org/r/551583