Page MenuHomePhabricator

implement loading bar timing in App
Closed, ResolvedPublic

Description

  • if app is ready within 1 second, show data bridge app
  • if app is ready between 1 and 1.5 seconds, wait until full 1.5 seconds have passed and show the app
  • if app is ready after more than 1.5 seconds, show the data bridge app

This should be implemented via the local state in the App component and (2?) timeout functions

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: Load progress bar if bridge is not ready
mediawiki/extensions/Wikibase : masterInitializing: animate loading
mediawiki/extensions/Wikibase : masterbridge: show progress bar while loading (prototype)

Related Objects

Event Timeline

Michael created this task.Nov 6 2019, 10:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2019, 10:54 AM

Change 550505 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Load progress bar after 1s

https://gerrit.wikimedia.org/r/550505

Change 551868 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: show progress bar while loading (with delay)

https://gerrit.wikimedia.org/r/551868

Change 551868 abandoned by Pablo Grass (WMDE):
bridge: show progress bar while loading (prototype)

Reason:
Alternative patch coming up

https://gerrit.wikimedia.org/r/551868

Change 553390 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Initializing: animate loading

https://gerrit.wikimedia.org/r/553390

Change 553390 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Initializing: animate loading

https://gerrit.wikimedia.org/r/553390

Mentioned in SAL (#wikimedia-cloud) [2019-11-29T13:09:39Z] <wm-bot> <migr> npm run build-storybook && tar -C storybook-static -c . | ssh toolforge "sudo -i -u tools.wikibase-databridge-storybook sh -c 'rm -rf www/static/*; tar -C www/static/ -x'" # deploy locally built storybook (T237513)

Change 550505 abandoned by Tonina Zhelyazkova:
bridge: Load progress bar if bridge is not ready

Reason:
This has been implemented in 553390 along with the rest of the loading progress bar logic.

https://gerrit.wikimedia.org/r/550505