Page MenuHomePhabricator

No error message for omitted </ref> tag
Closed, ResolvedPublic

Description

Author: FT2.wiki

Description:
A cite missing a </ref> tag will be reported as missing a <references /> tag instead. Example:

Fact fact fact.<ref>source.com

More fact fact fact...

==References==
<References />

renders with the error "There are <ref> tags on this page, but the references will not show without a <references/> tag", not "there is a missing </ref> tag".


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45415

Details

Reference
bz21798

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:49 PM
bzimport added a project: Cite.
bzimport set Reference to bz21798.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Dec 8 2009, 6:22 PM

chinchi29 wrote:

Suggest WONTFIX. A <references /> tag after a </ref> won't be detected because everything after the unclosed <ref> will be parsed as a reference (so the nested <references /> won't work). So, while the current message is a bit misleading, in a certain way it's correct.

FT2.wiki wrote:

Surely it's easy to check every <ref> is followed by a </ref>. REF tags can't presently be nested, so this is trivial to check. If an unclosed <ref> is detected, indicate this in the error message.

When there are no missing </ref>'s then show the current message instead.

  • Bug 27075 has been marked as a duplicate of this bug. ***

Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.

Change 119743 had a related patch set uploaded by AalekhN:
Adds proper error message

https://gerrit.wikimedia.org/r/119743

With the resolution of Bug 66860, there is no longer any error generated for this issue, it just renders the rest of the page oddly. See bug 67845.

  • Bug 67845 has been marked as a duplicate of this bug. ***

Patch doesn't do what we want and clearly isn't going to be fixed - setting NEW status. Are we sure this is an easy bug? Sounds like it would require a good knowledge of the parser to do...

Change 119743 abandoned by Alex Monk:
Adding proper error message

Reason:
Seems abandoned to me at this point. Feel free to restore if you're going to address the issues though.

https://gerrit.wikimedia.org/r/119743

AFAICS there's no special i18n issue here. Removing tag.

With the resolution of Bug 66860, a missing reference list is now automatically added. Before this was deployed, a page with a missing </ref> tag near the end of a page would eat the <references /> tag; this would trigger the error for a missing <references /> tag and editors were alerted that there was a problem. Now, there is no error and the following markup is rendered oddly.

Simple example:

<ref>1

<references />

Since there is no error detection, this is going to be a persistent issue and will be very difficult for novice editors to sort out. On enwiki, we had customized the error message so it linked to a help page that noted that the issue could be due to a missing </ref>.

Duplicate of Bug 15712

(In reply to Gadget850 from comment #12)

Duplicate of Bug 15712

Agreed.

  • This bug has been marked as a duplicate of bug 15712 ***
Meno25 removed a subscriber: Meno25.Oct 3 2016, 5:02 PM