Page MenuHomePhabricator

Visual Editor should not open edit window normally if user cannot create the page
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Enable Visual editor in Preferences
  2. Enable New wikitext mode in Beta features
  3. Click on a "red link" to any page that the user does not have permission to create because they are not an admin (eg https://en.wikipedia.org/wiki/MediaWiki:Gadget-XFDcloser-core?action=edit)

Expected result:
Similar to https://en.wikipedia.org/w/index.php?title=Add_content&action=edit&redlink=1, with at least an edit notice that the page is protected from creation

Actual result:
Normal-looking edit window appears, and the only notice is an edit notice is the standard notice to admins about editing in the mediawiki namespace

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Actual result:
Normal-looking edit window appears

I did not see a "Normal-looking edit window " when I clicked https://en.wikipedia.org/wiki/MediaWiki:Gadget-XFDcloser-core?action=edit
In fact there's no edit window at all, if there's one that would be a bug per T249978#6048312

...and the only notice is an edit notice is the standard notice to admins about editing in the mediawiki namespace

That's not editnotice. It's a standard core permission error message for lacking permission to create the page in NS_MEDIAWIKI. Perhaps over time some wikis may have over-modified it which makes it to start looking like something else.

This is the error message as provided by core unmodified. On enwiki even though it's modified, there's no edit window. Can you explain how can we reproduce the normal-looking edit window that you saw?

Screen Shot 2020-04-18 at 6.04.58 PM.png (293×1 px, 59 KB)

I use the new wikitext editor, and it proceeds to open the edit window --~~~~

Then that's a VE bug, but the bug report implied otherwise.

Ammarpad renamed this task from Don't open edit window normally if user cannot create the mediawiki: page to Visual Editor should not open edit window normally if user cannot create the page.Apr 18 2020, 5:35 PM
Ammarpad updated the task description. (Show Details)

Unfortunately the Editing team can not prioritize this at this time.

Actual result:
Normal-looking edit window appears, and the only notice is an edit notice is the standard notice to admins about editing in the mediawiki namespace

This might have been already fixed/improved? Indeed the editor opens as normal, which is confusing, but there is also a clear message that the page can't be edited (and you indeed can't type in the editor).

image.png (2×3 px, 535 KB)

Per previous comment