Regression: lost the ability to --dump-db-postrun
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	awight
	Nov 28 2019, 10:46 AM

Description

There used to be code which help a reference open to the backend database. Parts of this are RAII so destruction makes it impossible to work further with the database.

Probably, this was broken by my refactors. Restore!

See @hashar comments on https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/545309/ :

Broken since a663ad60cdffee3a19bee43c5b4a0bd0bd60f25a / https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/513520/

That breaks notably --dump-db-postrun

INFO:quibble.cmd:<<< Finish: Run tests in mediawiki/core: , in 0.107 s
INFO:backend.MySQL:Dumping database to /home/hashar/workspace/log/mysqldump.sql
Exception ignored in: <function MySQL.__del__ at 0x7fd20f528598>
Traceback (most recent call last):
  File "/home/hashar/projects/integration/quibble/quibble/backend.py", line 294, in __del__
  File "/home/hashar/projects/integration/quibble/quibble/backend.py", line 137, in stop
  File "/home/hashar/projects/integration/quibble/quibble/backend.py", line 278, in dump
NameError: name 'open' is not defined

With python 3.7

Details

	Subject	Repo	Branch	Lines +/-
	Release Quibble 0.0.45	integration/quibble	master	+54 -2
	Fix database dumping	integration/quibble	master	+7 -9

Customize query in gerrit

Related Objects

Mentioned Here: rQUIBBLEa663ad60cdff: MediaWiki installation... as command

Event Timeline

awight created this task.Nov 28 2019, 10:46 AM

DannyS712 added a project: Regression.Nov 28 2019, 12:42 PM

hashar updated the task description. (Show Details)Nov 28 2019, 1:46 PM

hashar subscribed.

awight moved this task from Backlog to Defect on the Quibble board.Apr 19 2020, 8:01 AM

Change 604380 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Fix database dumping

https://gerrit.wikimedia.org/r/604380

gerritbot added a project: Patch-For-Review.Jun 10 2020, 1:16 PM

Somehow now by the time MySQL.__del__ is invoked, the open built-in is already garbage collected. It seems weakref.finalize() is not affected and is the recommended way of handing it.