Page MenuHomePhabricator

Newcomer tasks - Suggested edits card shifted left after difficulty filter button is clicked
Open, Needs TriagePublicBUG REPORT

Assigned To
None
Authored By
Etonkovidova
Dec 5 2019, 9:26 PM
Referenced Files
F31458811: IMG_8615.PNG
Dec 5 2019, 9:26 PM
F31458813: IMG_8616.PNG
Dec 5 2019, 9:26 PM
F31268032: ooui bug pre dialog.png
Dec 5 2019, 9:26 PM
F31268041: ooui bug post dialog.png
Dec 5 2019, 9:26 PM

Description

As per @Tgr report:

When the modal dialog opens, the whole page can shift left. (Only seems to happen on narrow mobile screens; I saw it in desktop Chrome in mobile emulation mode using iPhone 8.) That's due to rGOJU6a5914dda8f8: Compensate for loss of margin when opening modals and not related to the patch, but it becomes much more jarring now that it affects the button that's being clicked. Not sure what to do about that; it seems like an OOUI bug, but maybe I just don't understand what it is for (or maybe it doesn't affect real mobile devices?).

before clickafter click
ooui bug pre dialog.png (1×750 px, 258 KB)
ooui bug post dialog.png (1×750 px, 256 KB)

It does affect real mobile devices - I've been observing it on iPhone 6s, where it looks like this:

Before clickAfter click
IMG_8615.PNG (1×640 px, 60 KB)
IMG_8616.PNG (1×640 px, 58 KB)

Note:The issue of the article card not fitting the screen (the navigation arrows are not quite visible) should be fixed after T238280 is resolved.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova renamed this task from Newcomer tasks - Suggested edits card shifted left after difficulty button is clicked to Newcomer tasks - Suggested edits card shifted left after difficulty filter button is clicked.Dec 5 2019, 9:29 PM