Page MenuHomePhabricator
Create Task
Maniphest T240053

Detect potential selser corruption
Closed, DuplicatePublic
Actions

Description

In T239875, unstripped dsr info from pasted content was being used during serialization but was detected since the node start was beyond the source length.

This task is to discuss if it's better to fail early when detecting the potential for corruption and explore other methods of detection.

Details

SubjectRepoBranchLines +/-
Account for getOrigSrc returning nullmediawiki/services/parsoidmaster+19 -7
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Dec 6 2019, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2019, 9:47 PM
ssastry renamed this task from Detect potentail selser corruption to Detect potential selser corruption.Dec 6 2019, 9:47 PM
gerritbot added a comment.Dec 6 2019, 9:47 PM

Change 554965 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Account for getOrigSrc returning null

https://gerrit.wikimedia.org/r/554965

gerritbot added a project: Patch-For-Review.Dec 6 2019, 9:47 PM
ssastry triaged this task as Medium priority.Dec 6 2019, 9:50 PM
gerritbot added a comment.Dec 6 2019, 9:55 PM

Change 554965 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Account for getOrigSrc returning null

https://gerrit.wikimedia.org/r/554965

Maintenance_bot removed a project: Patch-For-Review.Dec 6 2019, 10:10 PM
Stashbot mentioned this in T237693: Port templatedata mocha tests to phpunit.Dec 11 2019, 9:40 PM
Stashbot mentioned this in T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given.
Stashbot mentioned this in T237306: PEG error: Expected end of input or tlb but "\r" found..
Stashbot mentioned this in T239875: VE leaves around inline data-parsoid on edited content.

Mentioned in SAL (#wikimedia-operations) [2019-12-11T21:40:32Z] <arlolra> Updated Parsoid to af576d5 (T237693, T238777, T237306, T239875, T240053)

LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM
LGoto lowered the priority of this task from Medium to Low.Feb 21 2020, 5:19 PM
LGoto moved this task from Backlog to Tech Debt / Big changes on the Parsoid board.
ssastry closed this task as a duplicate of T182740: Detect when a page save is likely to be a corruption.Mar 5 2020, 10:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits