Maniphest T240921

Raw TemplateStyles is displayed as a text in the infocard heading on iOS application
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SerDIDG
	Dec 17 2019, 2:34 AM

Tags

Referenced Files

	F31521810: IMG_C3688347325F-1.jpeg
	Jan 23 2020, 12:28 AM

	F31478470: IMG_1162.PNG
	Dec 17 2019, 2:34 AM

	F31478467: IMG_1163.PNG
	Dec 17 2019, 2:34 AM

	F31478469: IMG_1161.PNG
	Dec 17 2019, 2:34 AM

Subscribers

Jack_who_built_the_house

Description

In Ruwiki we use TemplateStyles in many sport-related infocards to align icons in the heading. Seems like mobile application uses some kind of strip_tags to show heading contents from infocard in collapsible block, but doesn't sanitize and cutoff tag <style> properly.

Examples:
https://ru.m.wikipedia.org/wiki/Вудс,_Тайгер
https://ru.m.wikipedia.org/wiki/Зидан,_Зинедин

IMG_1163.PNG (2×1 px, 616 KB)

IMG_1162.PNG (2×1 px, 2 MB)

IMG_1161.PNG (2×1 px, 575 KB)

Event Timeline

SerDIDG created this task.Dec 17 2019, 2:34 AM

Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptDec 17 2019, 2:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jack_who_built_the_house subscribed.Dec 17 2019, 2:37 AM

SerDIDG updated the task description. (Show Details)Dec 17 2019, 2:37 AM

Anomie moved this task from Backlog to External on the TemplateStyles board.Dec 17 2019, 2:00 PM

LGoto triaged this task as Low priority.Dec 17 2019, 7:17 PM

LGoto added a project: iOS-app-v6.6-Penguin-On-A-Sled.

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Should be fixed when the app switches to mobile-html:

https://ru.wikipedia.org/api/rest_v1/page/mobile-html/Зидан,_Зинедин
https://ru.wikipedia.org/api/rest_v1/page/mobile-html/Вудс,_Тайгер

• JMinor moved this task from Tasks from Product Backlog to Waiting for Build on the iOS-app-v6.6-Penguin-On-A-Sled board.Dec 17 2019, 7:28 PM

JoeWalsh moved this task from Waiting for Build to Needs QA on the iOS-app-v6.6-Penguin-On-A-Sled board.Jan 17 2020, 6:44 PM

I am still seeing this on 6.6.0 (1706)

IMG_C3688347325F-1.jpeg (2×2 px, 1 MB)

JoeWalsh moved this task from Blocked or Waiting to Waiting for Build on the iOS-app-v6.6-Penguin-On-A-Sled board.Jan 23 2020, 10:18 AM

• JMinor moved this task from Waiting for Build to Needs QA on the iOS-app-v6.6-Penguin-On-A-Sled board.Mar 12 2020, 7:18 PM

Looks good now on 6.6.0 (1726)

This is now in beta and should be in the app store in the next week or two.