Maniphest T240959

🎬 desktop-de-21 | Change banner text – ⏰ 19.12.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kai.nissen
	Dec 17 2019, 3:25 PM

Tags

Referenced Files

None

Subscribers

CorinnaHillebrand_WMDE

Description

Banners are based on (variant) of desktop-de-20.

Acceptance Criteria

The sentence "Wikipedia ist ein Ort des Lernens – Werbung hat darin keinen Platz." is removed from the variant banner.
The sentence is always displayed in the control banner, regardless of the viewport width.
The control and variant banners are similar in height.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kai.nissen	T240958 🎬 desktop-de-21 \| Campaign setup – ⏰ 19.12.
		Resolved		kai.nissen	T240959 🎬 desktop-de-21 \| Change banner text – ⏰ 19.12.

Event Timeline

kai.nissen created this task.Dec 17 2019, 3:25 PM

tmletzko updated the task description. (Show Details)Dec 19 2019, 12:51 PM

CorinnaHillebrand_WMDE moved this task from Heap to Doing on the WMDE-FUN-Funban-2019 board.Dec 19 2019, 2:04 PM

CorinnaHillebrand_WMDE claimed this task.Dec 19 2019, 2:24 PM

the banners for saturday yet want to be checked, @tmletzko
https://de.wikipedia.org/?banner=B19_WMDE_21_ctrl
https://de.wikipedia.org/?banner=B19_WMDE_21_var

I'm working until 6pm today, after that @gabriel-wmde has to take over for making adjustments

looks good to me. you can enable for Saturday 17:00 UTC

CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Dec 19 2019, 4:00 PM

CorinnaHillebrand_WMDE moved this task from Doing to Code Review on the WMDE-FUN-Funban-2019 board.

CorinnaHillebrand_WMDE subscribed.

CorinnaHillebrand_WMDE moved this task from Code Review to Done on the WMDE-FUN-Funban-2019 board.Jan 3 2020, 9:57 AM

kai.nissen closed this task as Resolved.Jan 9 2020, 5:45 PM

kai.nissen claimed this task.