Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false
Closed, ResolvedPublic
Actions

Description

$wgDebugToolbar doesn't seem to be showing queries unless $wgDebugLogFile is turned on.

Expected behaviour: $wgDebugLogFile should not affect how $wgDebugToolbar works.

This seems like a regression, the same issue happened not that long ago with T231742 / 2e404a25828c713

Details

	Subject	Repo	Branch	Lines +/-
	rdbms: Fix debug toolbar query tab when $wgDebugLogFile is not set	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned Here: T231742: $wgDebugToolbar not showing SQL queries
rMW2e404a25828c: rdbms: Restore debug toolbar "Queries" feature

Event Timeline

Bawolff created this task.Dec 28 2019, 7:29 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptDec 28 2019, 7:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It should be noted that queries also no longer show up in the $wgDebugLogFile file, which I usually use as a catch-all for all debugging channels.

I don't get it, I changed nothing but this randomly started working :S. Oh well, sorry for the spam

Ok, I get it, the query tab of $wgDebugToolbar only shows up if $wgDebugLogFile is set to something

Bawolff renamed this task from Query tab of $wgDebugToolbar is broken to Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false.Dec 28 2019, 7:38 PM

Bawolff updated the task description. (Show Details)

Anomie removed a project: Platform Engineering.Jan 2 2020, 3:39 PM

Krinkle moved this task from Untriaged to Wiring for MediaWiki on the MediaWiki-libs-Rdbms board.Jan 29 2020, 4:33 AM

# $wgDebugLogFile = ''; (default)
$wgDebugToolbar = true;
$wgDebugDumpSql  = true;

Works for me so long as $wgDebugDumpSql is enabled given its powered by the PSR log channel internally. I suppose we can teach MWLBFactory to also auto-enable DBO_DEBUG mode baed on the DebugToolbar config.

Intro task for @holger.knust.

Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Feb 14 2020, 9:39 PM

• AMooney assigned this task to • holger.knust.Mar 17 2020, 8:27 PM

• AMooney triaged this task as Medium priority.

• AMooney edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

• AMooney moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.

WDoranWMF moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 2:30 PM

Change 583088 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/core@master] mediawiki: Fix query tab when $debugLogFile is not set

https://gerrit.wikimedia.org/r/583088

gerritbot added a project: Patch-For-Review.Mar 24 2020, 3:15 PM

• holger.knust moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 3:18 PM

• holger.knust moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 3:42 PM

Change 583088 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Fix debug toolbar query tab when $wgDebugLogFile is not set

https://gerrit.wikimedia.org/r/583088

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 24 2020, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2020, 4:12 PM

Krinkle closed this task as Resolved.Mar 24 2020, 10:10 PM