Page MenuHomePhabricator

Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false
Closed, ResolvedPublic


$wgDebugToolbar doesn't seem to be showing queries unless $wgDebugLogFile is turned on.

Expected behaviour: $wgDebugLogFile should not affect how $wgDebugToolbar works.

This seems like a regression, the same issue happened not that long ago with T231742 / 2e404a25828c713

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It should be noted that queries also no longer show up in the $wgDebugLogFile file, which I usually use as a catch-all for all debugging channels.

I don't get it, I changed nothing but this randomly started working :S. Oh well, sorry for the spam

Ok, I get it, the query tab of $wgDebugToolbar only shows up if $wgDebugLogFile is set to something

Bawolff renamed this task from Query tab of $wgDebugToolbar is broken to Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false.Dec 28 2019, 7:38 PM
Bawolff updated the task description. (Show Details)
# $wgDebugLogFile = ''; (default)
$wgDebugToolbar = true;
$wgDebugDumpSql  = true;

Works for me so long as $wgDebugDumpSql is enabled given its powered by the PSR log channel internally. I suppose we can teach MWLBFactory to also auto-enable DBO_DEBUG mode baed on the DebugToolbar config.

Change 583088 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/core@master] mediawiki: Fix query tab when $debugLogFile is not set

Change 583088 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Fix debug toolbar query tab when $wgDebugLogFile is not set