Page MenuHomePhabricator
Create Task
Maniphest T241883

Introducing $wgSitename and $wgGrammarForms on fy.wiktionary.org
Open, LowPublic
Actions

Description

Dear All,

Please, could someone set the sitename in $wgSitename[1] on fy.wiktionary.org to the project namespace, i.e. Wikiwurdboek, so {{SITENAME}} can be used for the translated form. This would be the finishing touch for completed task T202769[2]. Announcement has been done on the local 'village pump' page in exhibit [3], although I don't expect any response. (I'm still the only regular editor of the wiki.)

That's an easy one, isn't it? :-) Nevertheless, thank you very much in advance!

Update: I would like to expand the request using $wgGrammarForms. I'll write a patch for that.

Details

SubjectRepoBranchLines +/-
Introduce wgGrammarForms for fywiktionarymediawiki/extensions/WikimediaMessagesmaster+17 -0
[fywiktionary] Set a local wgSitenameoperations/mediawiki-configmaster+1 -0
Introduce wgGrammarForms for fywiktionarymediawiki/extensions/WikimediaMessagesmaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

PiefPafPier created this task.Jan 4 2020, 2:21 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptJan 4 2020, 2:21 PM
Aklapper added a project: Wikimedia-Site-requests.Jan 4 2020, 2:36 PM

Setting project to Wikimedia-Site-requests, as this request is about settings / configuration of a Wikimedia website. (Please follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting such kinds of changes.)

If you are curious and want to try making this configuration change yourself, please see https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests and give it a try!

PiefPafPier updated the task description. (Show Details)Jan 4 2020, 3:08 PM
Kizule moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.Jan 4 2020, 5:21 PM
PiefPafPier added a comment.Jan 4 2020, 6:01 PM
In T241883#5775227, @Aklapper wrote:

(...)
If you are curious and want to try making this configuration change yourself, please see https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests and give it a try!

Hi Aklapper, that's OK to me. Do I need additional user rights?

PiefPafPier claimed this task.Jan 4 2020, 10:31 PM
PiefPafPier triaged this task as Lowest priority.
PiefPafPier updated the task description. (Show Details)
PiefPafPier removed a subscriber: Liuxinyu970226.
PiefPafPier added a comment.Jan 5 2020, 9:40 PM
This comment was removed by PiefPafPier.
Aklapper added a comment.Jan 5 2020, 9:45 PM

Hi @PiefPafPier, thanks for taking a look at the code! As explained on https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests , "follow mw:Gerrit/Tutorial to create your first software change". It explains that proposed changes must be submitted in Gerrit to get reviewed. Thanks for your understanding. :)

PiefPafPier added a project: Patch-For-Review.Jan 5 2020, 9:47 PM
PiefPafPier moved this task from Config - to process to Analysis / under discussion on the Wikimedia-Site-requests board.Jan 5 2020, 9:50 PM
Aklapper removed a project: Patch-For-Review.Jan 5 2020, 10:04 PM

Patches must be in Gerrit, hence removing tag.

PiefPafPier renamed this task from Request to correct $wgSitename on fy.wiktionary.org to Introducing $wgSitename and $wgGrammarForms on fy.wiktionary.org.Jan 6 2020, 8:04 AM
PiefPafPier added a comment.Jan 7 2020, 2:16 PM

Patches are in Gerrit now ... Let's roll.
https://gerrit.wikimedia.org/r/562514 (Introduce wgGrammarForms for fywiktionary)
https://gerrit.wikimedia.org/r/562517 (Introduce wgSitename for fywiktionary)

PiefPafPier added a project: Patch-For-Review.Jan 7 2020, 2:18 PM
gerritbot added a comment.Jan 7 2020, 2:32 PM

Change 562514 had a related patch set uploaded (by Aklapper; owner: PiefPafPier):
[mediawiki/extensions/WikimediaMessages@master] Introduce wgGrammarForms for fywiktionary

https://gerrit.wikimedia.org/r/562514

gerritbot added a comment.Jan 7 2020, 2:32 PM

Change 562517 had a related patch set uploaded (by Aklapper; owner: PiefPafPier):
[operations/mediawiki-config@master] Introduce wgSitename for fywiktionary

https://gerrit.wikimedia.org/r/562517

PiefPafPier added a comment.Jan 8 2020, 8:23 AM

Added some helpful comments to the patch, and the option to use the abbreviated form of the article, which is actually used a lot after one-syllable prepositions. Language purists will love it.

PiefPafPier added a subscriber: MarcoAurelio.Jan 14 2020, 9:11 AM

@Aklapper, @MarcoAurelio, I would like to apologize for obviously doing something wrong again. I've uploaded a better patch, and included the Change-Id, so it would replace the previous patch. I thought I'd read that somewhere. The last patch - https://gerrit.wikimedia.org/r/c/562759 - is the final one. Could patch https://gerrit.wikimedia.org/r/c/562514 please be dropped?
Kind regards!

Aklapper added a comment.Jan 14 2020, 9:20 AM

Hi,

In T241883#5800933, @PiefPafPier wrote:

I've uploaded a better patch, and included the Change-Id, so it would replace the previous patch.

See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change how to amend a patch.

I thought I'd read that somewhere. The last patch - https://gerrit.wikimedia.org/r/c/562759 - is the final one. Could patch https://gerrit.wikimedia.org/r/c/562514 please be dropped?

You could. See "Abandon" on https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_comment_on,_review,_and_merge_code_in_Gerrit

PiefPafPier moved this task from Analysis / under discussion to Config - to process on the Wikimedia-Site-requests board.Feb 2 2020, 2:14 PM
gerritbot added a comment.Feb 12 2020, 7:13 PM

Change 562514 abandoned by Jforrester:
Introduce wgGrammarForms for fywiktionary

Reason:
Replaced by Ia9833807.

https://gerrit.wikimedia.org/r/562514

gerritbot added a comment.Feb 12 2020, 7:14 PM

Change 562759 had a related patch set uploaded (by Jforrester; owner: PiefPafPier):
[mediawiki/extensions/WikimediaMessages@master] Introduce wgGrammarForms for fywiktionary

https://gerrit.wikimedia.org/r/562759

gerritbot added a comment.Feb 12 2020, 7:15 PM

Change 562517 merged by jenkins-bot:
[operations/mediawiki-config@master] [fywiktionary] Set a local wgSitename

https://gerrit.wikimedia.org/r/562517

Stashbot added a comment.Feb 12 2020, 7:19 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-12T19:19:39Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T241883 [fywiktionary] Set a local wgSitename (duration: 01m 03s)

Jdforrester-WMF updated the task description. (Show Details)Feb 12 2020, 7:21 PM
PiefPafPier added a comment.EditedFeb 12 2020, 10:15 PM
In T241883#5878006, @gerritbot wrote:

Change 562759 had a related patch set uploaded (by Jforrester; owner: PiefPafPier):
[mediawiki/extensions/WikimediaMessages@master] Introduce wgGrammarForms for fywiktionary

https://gerrit.wikimedia.org/r/562759

@Jdforrester-WMF I took the Polish entry (pl) as an example, which doesn't have a 'LanguagePl.php' class ... (?)

PiefPafPier raised the priority of this task from Lowest to Low.Jul 3 2020, 4:00 AM
PiefPafPier added a subscriber: Jdforrester-WMF.Jul 4 2020, 5:03 AM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Aug 16 2022, 10:13 AM
Aklapper removed PiefPafPier as the assignee of this task.Sep 26 2022, 10:34 AM

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Stang moved this task from Config - to process to Working on on the Wikimedia-Site-requests board.Dec 20 2022, 3:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL