Page MenuHomePhabricator

Close button alignment and sizing
Closed, ResolvedPublicBUG REPORT


Steps to Reproduce:

  1. Generate a tainted reference warning in Beta
  2. Click the Tainted References icon to get the popper
  3. Hover over the frameless close button within the popper

Actual Results:

  1. The bottom padding of the frameless close button (space between the button and the header divider line) is greater than the top padding.

wrong_button_padding.png (168×378 px, 7 KB)

  1. The button icon size is too small.

Expected Results:

  1. The button is aligned in the header. There's an equal amount of vertical spacing at the top (between the button and popper outline) and at the bottom (between the button and the header divider).
  1. The size of the X icon should be 14px. It should be centred within a 32x32px button.

Please find specs in this Figma file.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sarai-WMDE renamed this task from Close button not vertically aligned in popper header to Close button alignment and sizing.Jan 8 2020, 11:45 AM
Sarai-WMDE updated the task description. (Show Details)

Change 566243 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Adjust close button position and size

Change 566243 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Adjust close button position and size

Reviewed! All Expected results are met. Great job! ʕ•ᴥ•ʔ