Page MenuHomePhabricator

Text and Feedback section of popper is misaligned
Closed, ResolvedPublicBUG REPORT


Looking at beta the popper should be like figma. However there is an abnormal about of margin on the left side of the text and the feedback link.


Event Timeline

Tarrow created this task.Jan 21 2020, 9:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2020, 9:39 AM

Change 566241 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Fix TaintedPopper content margins

During review can we triple check the alignment of the content now looks right? Seems I have a history of managing to miss something in these style patches.

Note: the patch does not resolve T242212.

Change 566241 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Fix TaintedPopper content margins

Reviewed. Left and right margins are even and aligned with Figma designs. Thanks for making the popper look so good and proportionate! ๑❛ᴗ❛๑

Lydia_Pintscher closed this task as Resolved.Jan 23 2020, 11:53 AM