Page MenuHomePhabricator
Create Task
Maniphest T243269

Text and Feedback section of popper is misaligned
Closed, ResolvedPublicBUG REPORT
Actions

Description

Looking at beta the popper should be like figma. However there is an abnormal about of margin on the left side of the text and the feedback link.

See:

image.png (223×482 px, 14 KB)

Details

SubjectRepoBranchLines +/-
TR: Fix TaintedPopper content marginsmediawiki/extensions/Wikibasemaster+9 -9
Customize query in gerrit

Related Objects

Event Timeline

Tarrow created this task.Jan 21 2020, 9:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2020, 9:39 AM
gerritbot added a comment.Jan 21 2020, 9:48 AM

Change 566241 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Fix TaintedPopper content margins

https://gerrit.wikimedia.org/r/566241

gerritbot added a project: Patch-For-Review.Jan 21 2020, 9:48 AM
Tarrow added a comment.Jan 21 2020, 9:49 AM

During review can we triple check the alignment of the content now looks right? Seems I have a history of managing to miss something in these style patches.

Note: the patch does not resolve T242212.

Tarrow moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.Jan 21 2020, 9:50 AM
Rosalie_WMDE moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint9 board.Jan 21 2020, 10:39 AM
Rosalie_WMDE moved this task from Done to Test (Product Review) on the Wikidata-Tainted-References-Sprint9 board.Jan 21 2020, 10:59 AM
gerritbot added a comment.Jan 21 2020, 10:59 AM

Change 566241 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Fix TaintedPopper content margins

https://gerrit.wikimedia.org/r/566241

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 21 2020, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 21 2020, 11:10 AM
Sarai-WMDE subscribed.Jan 23 2020, 9:43 AM

Reviewed. Left and right margins are even and aligned with Figma designs. Thanks for making the popper look so good and proportionate! ๑❛ᴗ❛๑

Sarai-WMDE moved this task from Test (Product Review) to Done on the Wikidata-Tainted-References-Sprint9 board.Jan 23 2020, 9:43 AM
Lydia_Pintscher closed this task as Resolved.Jan 23 2020, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL