Page MenuHomePhabricator

Unable to to add Structured Data to files that don't have any; "mainSnak.getValue is not a function" thrown in console
Closed, ResolvedPublic

Description

Since the deployment group1 wikis to 1.35.0-wmf.14 I am unable to add "Items portrayed in this file". Instead of an input field I see "no value", see screenshot

Event Timeline

Raymond created this task.Jan 8 2020, 9:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2020, 9:16 PM

TypeError: "mainSnak.getValue is not a function" in the console.

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 8 2020, 9:18 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJan 8 2020, 9:19 PM
Jdforrester-WMF added a comment.EditedJan 8 2020, 9:21 PM

For whatever reason, it doesn't seem to be broken on TestCommons. Belay that, just not on https://test-commons.wikimedia.org/wiki/File:Crystal-21.stl

Jdforrester-WMF renamed this task from unable to to add Structured Data to Unable to to add Structured Data to files that don't have any; "mainSnak.getValue is not a function" thrown in console.Jan 8 2020, 9:23 PM
Jdforrester-WMF added a project: SDC General.
Restricted Application added a project: Wikidata. · View Herald TranscriptJan 8 2020, 9:23 PM

For whatever reason, it doesn't seem to be broken on TestCommons. Belay that, just not on https://test-commons.wikimedia.org/wiki/File:Crystal-21.stl

It looks like the error happens on files with zero statements only. Your example above has statements already.

Commons rolled back to wmf.11

Change 562972 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562972

Change 562972 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562972

Change 562982 had a related patch set uploaded (by Jforrester; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.14] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562982

Change 562982 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.14] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562982

Mentioned in SAL (#wikimedia-operations) [2020-01-08T23:34:56Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.14/extensions/WikibaseMediaInfo/resources/statements/StatementWidget.js: T242286 Update StatementWidget initialization logic (duration: 01m 05s)

Jdforrester-WMF closed this task as Resolved.Jan 8 2020, 11:35 PM
Jdforrester-WMF assigned this task to AnneT.

Deployed to wmf.14.