Unable to to add Structured Data to files that don't have any; "mainSnak.getValue is not a function" thrown in console
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Raymond
	Jan 8 2020, 9:16 PM

Description

Since the deployment group1 wikis to 1.35.0-wmf.14 I am unable to add "Items portrayed in this file". Instead of an input field I see "no value", see screenshot

Details

	Subject	Repo	Branch	Lines +/-
	Update StatementWidget initialization logic	mediawiki/extensions/WikibaseMediaInfo	wmf/1.35.0-wmf.14	+4 -4
	Update StatementWidget initialization logic	mediawiki/extensions/WikibaseMediaInfo	master	+4 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T233862 1.35.0-wmf.14 deployment blockers
		Resolved		AnneT	T242286 Unable to to add Structured Data to files that don't have any; "mainSnak.getValue is not a function" thrown in console

Event Timeline

Raymond created this task.Jan 8 2020, 9:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2020, 9:16 PM

TypeError: "mainSnak.getValue is not a function" in the console.

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 8 2020, 9:18 PM

Jdforrester-WMF added a parent task: T233862: 1.35.0-wmf.14 deployment blockers.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJan 8 2020, 9:19 PM

~~For whatever reason, it doesn't seem to be broken on TestCommons.~~ Belay that, just not on https://test-commons.wikimedia.org/wiki/File:Crystal-21.stl

Jdforrester-WMF renamed this task from unable to to add Structured Data to Unable to to add Structured Data to files that don't have any; "mainSnak.getValue is not a function" thrown in console.Jan 8 2020, 9:23 PM

Jdforrester-WMF added a project: SDC General.

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 8 2020, 9:23 PM

In T242286#5788048, @Jdforrester-WMF wrote:

~~For whatever reason, it doesn't seem to be broken on TestCommons.~~ Belay that, just not on https://test-commons.wikimedia.org/wiki/File:Crystal-21.stl

It looks like the error happens on files with zero statements only. Your example above has statements already.

Commons rolled back to wmf.11

Agusbou2015 subscribed.Jan 8 2020, 9:36 PM

Change 562972 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562972

gerritbot added a project: Patch-For-Review.Jan 8 2020, 9:44 PM

Change 562972 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562972

Change 562982 had a related patch set uploaded (by Jforrester; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.14] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562982

Change 562982 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.14] Update StatementWidget initialization logic

https://gerrit.wikimedia.org/r/562982

Mentioned in SAL (#wikimedia-operations) [2020-01-08T23:34:56Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.14/extensions/WikibaseMediaInfo/resources/statements/StatementWidget.js: T242286 Update StatementWidget initialization logic (duration: 01m 05s)