Page MenuHomePhabricator
Create Task
Maniphest T242395

Misplaced Currency Symbol on Desktop Large - Nag banner in Hebrew
Closed, ResolvedPublicBUG REPORT
Actions

Description

The currency symbol for banners in Hebrew is misplaced (see attached screenshot)

MisplacedCurrencySymbolHebrew.png (96×1 px, 7 KB)

Steps to Reproduce:

  1. Open https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%90%D7%A1%22%D7%90&banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL
  2. Scroll down until nag appears
  3. Observe currency symbol appears to the left of text

Actual Results:
Currently the currency symbol appears to the left of the text

Expected Results:
We would expect the currency symbol to appear to the left of the number

Related Objects

Mentioned Here
P3 nagios-plugin-files

Event Timeline

• jbolorinos-ctr created this task.Jan 10 2020, 12:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2020, 12:00 AM
• jbolorinos-ctr removed subscribers: Pcoombe, spatton, Aklapper.Jan 10 2020, 12:08 AM
Pcoombe moved this task from Backlog to RTL on the Wikimedia-Fundraising-Banners board.Feb 19 2020, 4:59 PM
• jbolorinos-ctr triaged this task as Medium priority.Feb 19 2020, 5:38 PM

Updating priority to P3 since Big Bundle campaign needs this, but only affects one country

Pcoombe added a subscriber: • TSkaff.Feb 26 2020, 8:17 PM

I'm not sure how to fix this until we have the translations input. @TSkaff do you have an eta for that?

Pcoombe added a comment.Feb 27 2020, 4:10 PM

I think this is actually correct now that we have Hebrew text there: https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%90%D7%A1%22%D7%90&banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL

• TSkaff added a comment.Feb 27 2020, 4:25 PM

Responding to the above question ... Hebrew text are in Meta Translate (although not yet reviewed) ... so at least there is something to work with!

• jbolorinos-ctr added a comment.Feb 27 2020, 7:54 PM

I'm just going to keep this bug open for now until all of the translated text has been input.

Pcoombe updated the task description. (Show Details)Mar 3 2020, 8:49 PM
Pcoombe moved this task from RTL to Currently in QA on the Wikimedia-Fundraising-Banners board.Mar 4 2020, 1:26 PM
• jbolorinos-ctr closed this task as Resolved.Mar 4 2020, 4:52 PM
• jbolorinos-ctr claimed this task.

image.png (214×1 px, 48 KB)

Fix verified, closing this now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits