Page MenuHomePhabricator
Create Task
Maniphest T243744

Add tests for ContentHandler::getPageViewLanguage
Closed, ResolvedPublic
Actions

Description

Motivation:

At a glance, it seems like ContentHandlerTest doesn't cover the method ContentHandler::getPageViewLanguage.
https://doc.wikimedia.org/cover/mediawiki-core/includes/content/ContentHandler.php.html

Screenshot 2020-01-27 at 11.44.00.png (74×1 px, 23 KB)

Expected result:

  • More tests should be added.
  • ContentHandler::getPageViewLanguage should be covered 100%

Details

SubjectRepoBranchLines +/-
Add tests for ContentHandler::getPageViewLanguagemediawiki/coremaster+33 -0
Customize query in gerrit

Event Timeline

Peter.ovchyn created this task.Jan 27 2020, 9:44 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 27 2020, 9:44 AM
Peter.ovchyn updated the task description. (Show Details)Jan 27 2020, 10:25 AM
Peter.ovchyn updated the task description. (Show Details)Jan 27 2020, 11:31 AM
Peter.ovchyn removed a parent task: T226833: Introduce LanguageConverterFactory service.Jan 31 2020, 9:47 AM
daniel removed a project: Platform Engineering.Feb 5 2020, 7:28 PM
Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Feb 12 2020, 10:03 AM
Peter.ovchyn moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Mar 20 2020, 9:41 AM
Peter.ovchyn claimed this task.Mar 23 2020, 11:31 AM
Peter.ovchyn moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Mar 24 2020, 7:10 PM
Peter.ovchyn added a project: Patch-For-Review.
gerritbot added a comment.Mar 25 2020, 9:37 AM

Change 583297 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] Add tests for ContentHandler::getPageViewLanguage

https://gerrit.wikimedia.org/r/583297

gerritbot added a comment.Mar 31 2020, 3:18 PM

Change 583297 merged by jenkins-bot:
[mediawiki/core@master] Add tests for ContentHandler::getPageViewLanguage

https://gerrit.wikimedia.org/r/583297

DannyS712 removed a project: Patch-For-Review.Mar 31 2020, 3:19 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 4:00 PM
Peter.ovchyn moved this task from In Progress/In Review to Done on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 4:02 PM
Peter.ovchyn closed this task as Resolved.May 7 2020, 3:42 PM
Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Dec 27 2023, 6:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL