Page MenuHomePhabricator
Create Task
Maniphest T243869

DiscussionTools crashes if the discussion page has any comments before first section heading
Closed, ResolvedPublic
Actions

Description

DiscussionTools crashes if the discussion page has any comments before first section heading. For example: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Dog&diff=412204&oldid=412203

Details

SubjectRepoBranchLines +/-
Handle comments before first section headingmediawiki/extensions/DiscussionToolsmaster+78 -5
Customize query in gerrit

Event Timeline

matmarex created this task.Jan 29 2020, 12:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2020, 12:11 AM
matmarex claimed this task.Jan 29 2020, 12:11 AM
matmarex added a project: VisualEditor (Current work).
gerritbot added a comment.Jan 29 2020, 12:14 AM

Change 568141 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Handle comments before first section heading

https://gerrit.wikimedia.org/r/568141

gerritbot added a project: Patch-For-Review.Jan 29 2020, 12:14 AM
matmarex renamed this task from DiscussionTools crashes if the discussion page has any comments before first heading to DiscussionTools crashes if the discussion page has any comments before first section heading.Jan 29 2020, 12:17 AM
matmarex updated the task description. (Show Details)
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jan 29 2020, 12:19 AM
ppelberg subscribed.Jan 30 2020, 5:55 AM

Good catch, @matmarex.

gerritbot added a comment.Jan 30 2020, 11:19 PM

Change 568141 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Handle comments before first section heading

https://gerrit.wikimedia.org/r/568141

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jan 30 2020, 11:59 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 31 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2020, 12:10 AM
matmarex added a project: Editing QA.Feb 3 2020, 6:52 PM
JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work).Feb 4 2020, 11:14 PM
JTannerWMF moved this task from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
JTannerWMF added a project: OWC2020 Replying 1.0.
JTannerWMF added a project: OWC2020 (OWC2020 Replying 1.0).Feb 4 2020, 11:29 PM
JTannerWMF moved this task from Inbox to High Priority on the Editing QA board.Feb 5 2020, 3:05 AM
Ryasmeen edited projects, added Verified; removed Editing QA.Feb 10 2020, 8:14 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
JTannerWMF moved this task from Needs Prioritization to Required before Release on the OWC2020 (OWC2020 Replying 1.0) board.Feb 10 2020, 10:34 PM
ppelberg closed this task as Resolved.Feb 11 2020, 1:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL