Page MenuHomePhabricator

Parser::getTitle() is not allowed to return null, eventhough it can happen
Closed, DuplicatePublicBUG REPORT

Description

Paser::getTitle() method explicitly defines it returning a Title object, but in case Parser::setTitle( Title ) was not called, it will try to return null.
Eventhough in most cases, Parser::setTitle() will be called internally, there is no guarantee that will happen, so no guarantee that Parser->mTitle will be a valid Title object

Details

Related Changes in Gerrit:

Event Timeline

Change 571940 had a related patch set uploaded (by ItSpiderman; owner: ItSpiderman):
[mediawiki/core@master] Allow Parser::getTitle() return null

https://gerrit.wikimedia.org/r/571940

Change 571940 abandoned by ItSpiderman:
Allow Parser::getTitle() return null

Reason:
also fixed in 533559

https://gerrit.wikimedia.org/r/571940