We get some Javascript libraries via CDN. We should instead import them directly to the project and stop relying on external hosting.
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T240153 Address project technical debt | |||
Resolved | Shubh1815 | T245270 Stop using external Javascript hosting |
Event Timeline
Hey @Samwalton9, I am getting this error when I run tests, and I am not able to figure out why, as I haven't changed any code after I made the PR and before creating the PR I had ran the tests and it didn't gave any error at that time.
django.db.transaction.TransactionManagementError: An error occurred in the current transaction. You can't execute queries until the end of the 'atomic' block.
Thanks @Scardenasmolinar, its working now. Also, can you explain how rebasing the branch fixed it?
@Shubh1815 You branch was probably out of date with the master branch. By rebasing, you get your branch up to date, which can fix errors you might have been having.
Merged, thanks!
@Samwalton9 a previous contributor had moved our javascript hosting to the tools static proxy, which resolved the underlying privacy concern behind the security team's recommendation to avoid external asset hosting. My guess is that this is why you closed this out. Moving them into the platform is a cleaner approach, IMO, so I consider this an improvement.