Page MenuHomePhabricator

Implement Diff view for Jade Entity UI
Closed, ResolvedPublic

Description

We need to create a separate widget for embedded context on a Jade Entity page.

This would be something like DiffWidget and then we add it to ext.Jade.entityView inside of a Panel widget / Stack layout.

The widget will need to call the compare api module and dynamically add a diff view above the Facets list.

Design mockups are here: https://phabricator.wikimedia.org/T212370

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2020, 10:35 PM

Change 572362 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] [WIP] Implement Diff view for Jade Entity UI

https://gerrit.wikimedia.org/r/572362

ACraze updated the task description. (Show Details)Feb 14 2020, 10:49 PM

Moving this to the review column for now. There might be some edge cases I haven't caught yet, however we now have a functional diff and header.

Here's a quick screenshot:

Change 572362 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Implement Diff view for Jade Entity UI

https://gerrit.wikimedia.org/r/572362

ACraze added a comment.EditedMar 4 2020, 6:34 PM

After some testing on beta, it seems the DiffWidget is handling initial revisions incorrectly, see:

https://deployment.wikimedia.beta.wmflabs.org/wiki/Jade:Diff/1337

https://deployment.wikimedia.beta.wmflabs.org/w/api.php?action=compare&fromrev=1337&torelative=prev

Fix incoming...

Change 576937 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Use revid for diff widget

https://gerrit.wikimedia.org/r/576937

Change 576937 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Use revid for diff widget

https://gerrit.wikimedia.org/r/576937

Change 577009 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Handle initial revision diff

https://gerrit.wikimedia.org/r/577009

Change 577009 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Handle initial revision diff

https://gerrit.wikimedia.org/r/577009

Halfak closed this task as Resolved.Mon, Jun 22, 4:35 PM