| • ACraze | |
| Feb 14 2020, 10:35 PM |
| F31660881: Screenshot from 2020-03-03 17-31-37.png | |
| Mar 4 2020, 1:42 AM |
We need to create a separate widget for embedded context on a Jade Entity page.
This would be something like DiffWidget and then we add it to ext.Jade.entityView inside of a Panel widget / Stack layout.
The widget will need to call the compare api module and dynamically add a diff view above the Facets list.
Design mockups are here: https://phabricator.wikimedia.org/T212370
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T212435 Review real-world query plans and performance for Jade | |||
| Declined | None | T238877 Write Huggle labels to Jade | |||
| Declined | calbon | T183381 Deploy pilot of Jade to a small set of wikis. | |||
| Resolved | • ACraze | T229973 Implement Jade Entity pages | |||
| Resolved | • ACraze | T208819 Implement Jade Entity UI | |||
| Resolved | • ACraze | T245316 Implement Diff view for Jade Entity UI |
Change 572362 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] [WIP] Implement Diff view for Jade Entity UI
Moving this to the review column for now. There might be some edge cases I haven't caught yet, however we now have a functional diff and header.
Here's a quick screenshot:
Change 572362 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Implement Diff view for Jade Entity UI
After some testing on beta, it seems the DiffWidget is handling initial revisions incorrectly, see:
https://deployment.wikimedia.beta.wmflabs.org/wiki/Jade:Diff/1337
https://deployment.wikimedia.beta.wmflabs.org/w/api.php?action=compare&fromrev=1337&torelative=prev
Fix incoming...
Change 576937 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Use revid for diff widget
Change 576937 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Use revid for diff widget
Change 577009 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Handle initial revision diff
Change 577009 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Handle initial revision diff