Page MenuHomePhabricator

Implement Jade Entity UI
Closed, ResolvedPublic


We have a rudimentary view for judgment pages. Screenshot attached.

Screen Shot 2018-11-05 at 3.38.14 PM.png (1×1 px, 139 KB)

We should consider what we want the final design to look like based on results from user testing. Some early ideas I have are to embed context in the page so that you don't have to look up the diff.

See the current prototype live:

Event Timeline

Some early ideas I have are to embed context in the page so that you don't have to look up the diff.

Yes, thanks! I can go ahead and implement something basic, then we can style later.

Thinking we can borrow the RC list style. Right below the page title, a line line:

16:08 Wikimedia Foundation‎ (diff | hist) . . (-20)‎ . . 2600:1:C774:AA58:A15D:999C:A204:2F10 (talk) (Hb) (Tags: Mobile edit, Mobile web edit)

Harej triaged this task as Medium priority.Nov 14 2018, 11:46 PM

Oops! The text is not translatable yet, this is a bug.

This turns out to be a crude and fragile implementation, but for illustration

Screen Shot 2018-11-14 at 5.30.54 PM.png (602×1 px, 91 KB)

A diff line might have better formatting, but still isn't quite right:

(cur | prev) 14:43, 22 September 2018‎ Admin (talk | contribs)‎ . . (243 bytes) (+243)‎ . . (Created page with "{ "judgments": [ { "schema": { "damaging": true }, "preferred": true }, { "schema": {...")

We might have to create a new interface in the core RC classes, to allow more flexibility.

Change 473652 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/JADE@master] [WIP] Render a summary of the target wiki entity

@Harej is clarifying in IRC that "context" can be the full 1- or 2- column diff, not just a summary line.

We need to design how this will fit onto a page that also has judgment controls.

awight renamed this task from Come up with view mode for JADE pages to Design view mode for JADE pages.Dec 19 2018, 10:50 PM
Harej renamed this task from Design view mode for JADE pages to Jade Implementation: Entry view mode.Dec 19 2018, 11:15 PM

Change 473652 abandoned by Ladsgroup:
[WIP] Render a summary of the target wiki entity

The patch needs so much work that remaking it would make more sense now, plus we need to archive this extension in favor of "Jade" so feel free to cherry-pick the commit into the other extension and continue working on it if you think it makes sense.

Halfak renamed this task from Jade Implementation: Entry view mode to Implement Jade Entity UI.Aug 6 2019, 8:07 PM
Halfak added a subscriber: Harej.

Change 552616 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] WIP: Implement Jade entity UI

Adding a gif of the prototype demo shown in today's sync meeting:

jade-ui-dec-2019.gif (820×1 px, 1 MB)

This shows how to endorse a label, delete an endorsement, propose a new label and promote a label as consensus.


  • CSS styling (obviously)
  • wire up "Move Endorsement" form
  • fix edit form read-only issues for proposal and endorsement
  • fix requirejs & jquery loading issue
  • add diff view

Adding an updated gif here showing some basic CSS, the new "logged-in" author components and also the WIP padding issue for API errors in pop-up forms (shown by trying to delete a 'preferred' label)

jade-ui-jan-2020.gif (820×1 px, 448 KB)

Change 552616 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Implement Jade entity UI