Page MenuHomePhabricator

Implement Jade Entity UI
Open, NormalPublic

Description

We have a rudimentary view for judgment pages. Screenshot attached.

We should consider what we want the final design to look like based on results from user testing. Some early ideas I have are to embed context in the page so that you don't have to look up the diff.

See the current prototype live:
https://en.wikipedia.beta.wmflabs.org/wiki/Judgment:Diff/376901
https://en.wikipedia.beta.wmflabs.org/wiki/Judgment:Revision/376901

Event Timeline

Harej created this task.Nov 5 2018, 11:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2018, 11:41 PM
Harej moved this task from Product to Feature Requests on the Jade board.Nov 5 2018, 11:41 PM

Some early ideas I have are to embed context in the page so that you don't have to look up the diff.

Yes, thanks! I can go ahead and implement something basic, then we can style later.

Thinking we can borrow the RC list style. Right below the page title, a line line:

16:08 Wikimedia Foundation‎ (diff | hist) . . (-20)‎ . . 2600:1:C774:AA58:A15D:999C:A204:2F10 (talk) (Hb) (Tags: Mobile edit, Mobile web edit)

Harej triaged this task as Normal priority.Nov 14 2018, 11:46 PM

Oops! The text is not translatable yet, this is a bug.

awight added a comment.EditedNov 15 2018, 1:35 AM

This turns out to be a crude and fragile implementation, but for illustration

A diff line might have better formatting, but still isn't quite right:

(cur | prev) 14:43, 22 September 2018‎ Admin (talk | contribs)‎ . . (243 bytes) (+243)‎ . . (Created page with "{ "judgments": [ { "schema": { "damaging": true }, "preferred": true }, { "schema": {...")

We might have to create a new interface in the core RC classes, to allow more flexibility.

Change 473652 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/JADE@master] [WIP] Render a summary of the target wiki entity

https://gerrit.wikimedia.org/r/473652

@Harej is clarifying in IRC that "context" can be the full 1- or 2- column diff, not just a summary line.

We need to design how this will fit onto a page that also has judgment controls.

awight updated the task description. (Show Details)Nov 19 2018, 9:00 PM
awight renamed this task from Come up with view mode for JADE pages to Design view mode for JADE pages.Dec 19 2018, 10:50 PM
Harej renamed this task from Design view mode for JADE pages to Jade Implementation: Entry view mode.Dec 19 2018, 11:15 PM
awight removed a subscriber: awight.Mar 21 2019, 4:04 PM

Change 473652 abandoned by Ladsgroup:
[WIP] Render a summary of the target wiki entity

Reason:
The patch needs so much work that remaking it would make more sense now, plus we need to archive this extension in favor of "Jade" so feel free to cherry-pick the commit into the other extension and continue working on it if you think it makes sense.

https://gerrit.wikimedia.org/r/473652

Harej removed a subscriber: Harej.Jul 4 2019, 9:26 AM
Halfak renamed this task from Jade Implementation: Entry view mode to Implement Jade Entity UI.Aug 6 2019, 8:07 PM
Halfak added a subscriber: Harej.
Prtksxna removed a subscriber: Prtksxna.Aug 7 2019, 5:08 AM