Page MenuHomePhabricator
Create Task
Maniphest T245602

FlaggedRevs: redundant style definitions for fr-watchlist-pending-notice
Closed, ResolvedPublic
Actions

Description

Since rEFLR985dc2b5d569df5ccf2567f18bd5f6fbe60f8658 by @Jdlrobson the mw-fr-watchlist-pending-notice message ("there are unreviewed changes on your watchlist") uses the warningbox class which comes with styling by default.

In rEFLR frontend/modules/ext.flaggedRevs.basic.css:224-230 (at f5d01c4f70b4) we have redundant and deviant styling for this div by class fr-watchlist-pending-notice (more like errorbox).

As the fr-watchlist-pending-notice class seems to be used nowhere else I propose to remove it completely. For users who want to hide the message it is possible to access it by id.

Related Objects

Event Timeline

hgzh created this task.Feb 19 2020, 11:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2020, 11:21 AM
XanonymusX subscribed.Feb 20 2020, 11:25 AM

Was the change related to T237246?

Wugapodes moved this task from Backlog to UI/UX errors on the FlaggedRevs board.Mar 16 2021, 9:47 PM
Tacsipacsi updated the task description. (Show Details)Sep 22 2021, 6:20 PM
Tacsipacsi subscribed.

It’s always a good idea to refer to a specific commit when talking about source code. The redundant CSS is still there, but it was off by 60 lines by now because of other cleanup work.

hgzh closed this task as Resolved.Mar 22 2022, 8:24 AM
hgzh claimed this task.

Should be resolved with https://gerrit.wikimedia.org/r/772046

hgzh removed hgzh as the assignee of this task.Mar 22 2022, 8:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits