Page MenuHomePhabricator
Create Task
Maniphest T245776

VisualEditor toolbar tools fix
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Navigate to Visual
  2. Verify structure, style text, page options and switch editor tools have accessible label

Actual Results:
toolbar tools identified above are not accessible

Expected Results:
Toolbar tools must be accessibile

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (61d8fefba)mediawiki/extensions/VisualEditormaster+1 -1
Add accessibility labels to all `type: 'list'` toolbar groupsmediawiki/extensions/VisualEditormaster+18 -1
Add accessibility labels to all `type: 'list'` toolbar groupsVisualEditor/VisualEditormaster+14 -2
Add `aria-label` to list of tool groupsVisualEditor/VisualEditormaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

Akinwale-microsoft created this task.Feb 20 2020, 8:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2020, 8:24 PM
gerritbot added a comment.Feb 20 2020, 8:24 PM

Change 573686 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[VisualEditor/VisualEditor@master] Fix: making toolbar list tools accessibile

https://gerrit.wikimedia.org/r/573686

gerritbot added a project: Patch-For-Review.Feb 20 2020, 8:24 PM
gerritbot added a comment.Mar 13 2020, 9:11 PM

Change 579631 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Add accessibility labels to all type: 'list' toolbar groups

https://gerrit.wikimedia.org/r/579631

gerritbot added a comment.Mar 13 2020, 9:11 PM

Change 579633 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Add accessibility labels to all type: 'list' toolbar groups

https://gerrit.wikimedia.org/r/579633

matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Mar 13 2020, 9:13 PM
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
gerritbot added a comment.Mar 19 2020, 7:24 PM

Change 573686 abandoned by Esanders:
Add aria-label to list of tool groups

https://gerrit.wikimedia.org/r/573686

gerritbot added a comment.Mar 19 2020, 7:30 PM

Change 579631 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Add accessibility labels to all type: 'list' toolbar groups

https://gerrit.wikimedia.org/r/579631

gerritbot added a comment.Mar 19 2020, 7:34 PM

Change 581717 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (61d8fefba)

https://gerrit.wikimedia.org/r/581717

gerritbot added a comment.Mar 19 2020, 7:34 PM

Change 581717 abandoned by Esanders:
Update VE core submodule to master (61d8fefba)

https://gerrit.wikimedia.org/r/581717

gerritbot added a comment.Mar 19 2020, 7:35 PM

Change 579633 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add accessibility labels to all type: 'list' toolbar groups

https://gerrit.wikimedia.org/r/579633

gerritbot added a comment.Mar 19 2020, 7:53 PM

Change 581717 restored by Jforrester:
Update VE core submodule to master (61d8fefba)

https://gerrit.wikimedia.org/r/581717

gerritbot added a comment.Mar 19 2020, 8:07 PM

Change 581717 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (61d8fefba)

https://gerrit.wikimedia.org/r/581717

matmarex claimed this task.Mar 19 2020, 8:16 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 19 2020, 8:49 PM
JTannerWMF reassigned this task from matmarex to • marcella.Mar 20 2020, 9:57 AM
JTannerWMF added a subscriber: matmarex.
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.Mar 24 2020, 3:21 PM
ppelberg closed this task as Resolved.Apr 11 2020, 12:46 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 11 2020, 12:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits