Cannot read property 'session' of undefined
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Feb 27 2020, 6:02 AM

Description

Getting this on a fresh vagrant box with the flow role; it breaks the Flow pages (they look OK but are unresponsive):

load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=11buy:52 Uncaught TypeError: Cannot read property 'session' of undefined
    at new mwFlowUiNewTopicWidget (<anonymous>:442:136)
    at mw.flow.Initializer.setupNewTopicWidget (<anonymous>:518:484)
    at mw.flow.Initializer.initializeWidgets (<anonymous>:515:62)
    at HTMLDocument.<anonymous> (<anonymous>:533:408)
    at mightThrow (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=11buy:49)
    at process (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=11buy:49)

Details

	Subject	Repo	Branch	Lines +/-
	Declare missing dependency on mediawiki.storage	mediawiki/extensions/Flow	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned Here: T133629: Split Flow role
rMW2290afbed95f: mediawiki.user: Switch sessionId() back to session-cookie persistence
T246313: Vagrant flow role: SELECT command denied to user 'wikiadmin'@'localhost' for table 'flow_revision'

Event Timeline

Tgr created this task.Feb 27 2020, 6:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2020, 6:02 AM

This was right after T246313: Vagrant flow role: SELECT command denied to user 'wikiadmin'@'localhost' for table 'flow_revision' so maybe some kind of secondary error, although the wiki seems to have recovered from that problem just fine.

The error refers to mw.storage which is indeed undefined. I wonder if it's an undeclared dependency which has now disappeared due to rMW2290afbed95f: mediawiki.user: Switch sessionId() back to session-cookie persistence...

Change 575240 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Declare missing dependency on mediawiki.storage

https://gerrit.wikimedia.org/r/575240

gerritbot added a project: Patch-For-Review.Feb 27 2020, 1:24 PM

kostajh added a project: Growth-Team (Sprint 0 (Growth Team)).Feb 27 2020, 1:24 PM

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 575240 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Declare missing dependency on mediawiki.storage

https://gerrit.wikimedia.org/r/575240

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 2 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2020, 11:10 AM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 2 2020, 12:35 PM

@Tgr -there are two Flow roles (https://phabricator.wikimedia.org/T133629) flow and wikimediaflow. When I enable wikimediaflow role, there is still the error about session.

Warning: session_name(): Cannot change session name when headers already sent in /vagrant/mediawiki/includes/Setup.php on line 779

I'm not sure whether it's a new bug (or even if wikimediaflow is relevant at all). The split was based on whether a role depends on External store. If wikimediaflow role should be used at all?

Definetly a bug (if wikimediaflow shouldn't be used, it shouldn't exist; if it exists, it should work), but not related to this one. (Also, PHP "headers already sent" errors are just a byproduct of a different error, and not really informative.)

Thx, @Tgr - I'll follow up on wikimediaflow to see if the issue requires fixing.

Cannot read property 'session' of undefined Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Cannot read property 'session' of undefined
Closed, ResolvedPublic
Actions