Runnning tests on PHP 8:
Deprecated: Required parameter $rules follows optional parameter $value in mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Directive.php on line 20
Runnning tests on PHP 8:
Deprecated: Required parameter $rules follows optional parameter $value in mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Directive.php on line 20
What's funnier, is the code manages it anyway
https://github.com/wikimedia/less.php/blob/master/lib/Less/Tree/Directive.php#L20-L31
public function __construct($name, $value = null, $rules, $index = null, $currentFileInfo = null, $debugInfo = null ){ $this->name = $name; $this->value = $value; if( $rules ){ $this->rules = $rules; $this->rules->allowImports = true; } $this->index = $index; $this->currentFileInfo = $currentFileInfo; $this->debugInfo = $debugInfo; }
Fix is easy
Should we just close this task as the issue is resolved? PHP 8.0 is not gonna be released anytime soon (late 2021, probably), and I'm guessing we'll have released something by then. Or jfdi a minor minor release to get it out?
I think we should at least try to use Travis' php-nightly to be ready for new PHP's coming.
Feel free to add it, but personally I'd rather not have one extra thing to need to monitor (given it'd have to be non-voting in Travis). I'd rather spend the time on such refactoring in narrower and more focussed windows of time (with high signal-to-noise ratio), for specific versions we want to support. E.g. when there's an RC or beta version, we could proactively add it to the mix if we want to.
PHP 8.0 is not gonna be released anytime soon (late 2021, probably)
Actually, it's late this year, and first alphas will arrive only in 3 months.