Page MenuHomePhabricator

[Bug] Mobile-html first edit pencil in the wrong place
Closed, ResolvedPublic

Description

The first edit pencil should be lower, where the introduction text is. In the mobile-html endpoint it is showing next to the article title.

Expected (iOS version 6.5.1):

IMG_0094.PNG (1×750 px, 1 MB)

Actual (iOS version 6.6.0):

IMG_0095.PNG (1×750 px, 1 MB)

Event Timeline

To change this we would have to change the HTML markup. I think for this one we should come to an agreement between Android and iOS designers. The current way the mobile-html output shows the first edit pencil is how the Android app has done it in the past. If we change it to the way iOS does it then it'll change for Android since we want to avoid sending different HTML for Android vs iOS.

To clarify this is blocked until there is agreement between iOS and Android designers about where the first edit pencil should go.

@Charlotte @schoenbaechler @JMinor @cmadeo could y'all discuss and agree on an edit pencil location for the first section for both platforms? The two options are the screenshots in the description - either by the title or by the first section text.

Thanks for pulling this all together. I just met with @schoenbaechler and we've agreed that the pencil should appear by the first section text. Although this will be a change for Android, we're hoping that it will help to simplify the header area which can currently have a variety of different CTAs based on contribution type (on Android) and will soon feature some new experiments on iOS.

Change 588537 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Move first edit button from title to lead paragraph

https://gerrit.wikimedia.org/r/588537

Change 588537 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Move first edit button from title to lead paragraph

https://gerrit.wikimedia.org/r/588537

Deployed earlier today. It took a while for the cached PCS JS module to get purged.