Update parserTests in ParserFunctions extension to v2
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Apr 1 2020, 4:51 PM

Description

ParserTests are the only place where we still run the parser in "no tidy" mode. We need to update the output of the parserTests used by this extension to have properly tidied output. Adding !! version 2 as the first line of your parserTests file opts in to this new behavior, and you can easily see which tests fail. Usually the clean up is pretty straightforward.

See https://gerrit.wikimedia.org/r/565146 for a description of typical fixups.

See https://gerrit.wikimedia.org/r/568093 patchset 1 for how to get started (just add !! version 2 to all your parser tests files and see what breaks!

Details

	Subject	Repo	Branch	Lines +/-
	Update parserTests to v2 (tidy by default)	mediawiki/extensions/ParserFunctions	master	+66 -60

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T261329 Prepare Parsoid for MW
Resolved	cscott	T198214 Deprecate and remove non-remex Tidy modes of the core parser
Resolved	cscott	T174199 Get rid of the non-Tidy option in parser tests
Resolved	cscott	T249138 Update parserTests in ParserFunctions extension to v2

Event Timeline

cscott created this task.Apr 1 2020, 4:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 4:51 PM

cscott added a parent task: T174199: Get rid of the non-Tidy option in parser tests.Apr 1 2020, 4:51 PM

Change 585309 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ParserFunctions@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585309

gerritbot added a project: Patch-For-Review.Apr 1 2020, 8:03 PM

Change 585309 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585309

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 1 2020, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2020, 10:10 PM

cscott closed this task as Resolved.May 1 2020, 8:51 PM

cscott claimed this task.