Page MenuHomePhabricator
Create Task
Maniphest T198214

Deprecate and remove non-remex Tidy modes of the core parser
Closed, ResolvedPublic
Actions

Assigned To
cscott
Authored By
cscott
Jun 26 2018, 1:39 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Arlolra
cscott
gerritbot
Jdforrester-WMF
Legoktm
Ricordisamoa
View All 10 Subscribers
Tokens
"Orange Medal" token, awarded by Krinkle.

Description

Set the stage for eventual migration of the core parser to Parsoid by deprecating and removing unsupported non-tidy and non-remex-tidy modes of the core parser.

Details

SubjectRepoBranchLines +/-
Remove calls to ParserOptions::setTidy()mediawiki/extensions/ParserMigrationmaster+0 -2
Tweak Tidy handling in editTests.phpmediawiki/coremaster+3 -11
Get rid of ParserOptions::setTidy()mediawiki/coremaster+2 -12
Start hard deprecating +tidy uses in parser test filesmediawiki/services/parsoidmaster+3 -5
Get rid of +tidy references from parser testsmediawiki/extensions/InputBoxmaster+23 -23
Get rid of +tidy, +untidy references from parser testsmediawiki/extensions/SyntaxHighlight_GeSHimaster+4 -9
Get rid of +tidy references from parser testsmediawiki/extensions/ChessBrowsermaster+2 -2
Get rid of +tidy references from parser testsmediawiki/extensions/WikiSEOmaster+9 -9
Get rid of +tidy reference in parser testsmediawiki/services/parsoidmaster+77 -76
Get rid of +untidy testsmediawiki/services/parsoidmaster+3 -22
Deprecate MWTidy and TidyDriverBase::supportsValidate()mediawiki/coremaster+57 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/TinyMCEmaster+5 -5
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/FundraisingEmailUnsubscribemaster+1 -1
Remove all methods of MWTidy except for MWTidy::tidy()mediawiki/coremaster+9 -75
Remove calls to ParserOptions::setTidy()mediawiki/extensions/BlueSpiceFoundationmaster+0 -1
Remove calls to ParserOptions::setTidy()mediawiki/extensions/BlueSpiceFoundationREL1_35+0 -1
Remove 'tidy' from ParserOptionsmediawiki/coremaster+8 -15
Remove calls to ParserOptions::setTidy()mediawiki/extensions/UploadWizardmaster+0 -1
Remove calls to ParserOptions::setTidy()mediawiki/extensions/AbuseFiltermaster+0 -1
Remove ParserBeforeTidy hook, deprecated in 1.35mediawiki/coremaster+1 -36
Remove calls to ParserOptions::setTidy()mediawiki/extensions/Echomaster+0 -1
Remove calls to ParserOptions::setTidy()mediawiki/extensions/Flowmaster+0 -2
Remove calls to ParserOptions::setTidy()mediawiki/extensions/VEForAllmaster+1 -2
Remove calls to ParserOptions::setTidy()mediawiki/extensions/DocBookExportmaster+3 -1
Remove calls to ParserOptions::setTidy()mediawiki/extensions/Commentsmaster+1 -2
Tidy is no longer configurable in MW 1.35mediawiki/extensions/TextExtractsmaster+20 -29
Deprecate a few more tidy-related methodsmediawiki/coremaster+7 -3
Always tidy the parser outputmediawiki/extensions/BlueSpiceSocialmaster+1 -31
Use MWTidy::tidy() directlymediawiki/extensions/BlueSpiceFoundationmaster+1 -2
Remove codepaths which ran parser in 'untidy' modemediawiki/coremaster+45 -327
Deprecate ParserOptions::getTidy() and ParserOptions::setTidy()mediawiki/coremaster+5 -7
Update parserTests to v2 format (default html/php tests to tidy)mediawiki/coremaster+0 -0
Support `html+untidy` tests and version flag in parserTests filemediawiki/coremaster+43 -5
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/skins/Nimbusmaster+5 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/WikiArticleFeedsmaster+1 -1
Remove deprecated non-tidy OutputPage::parse/parseInline methodsmediawiki/coremaster+8 -171
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/WikiForummaster+2 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/TranslateSvgmaster+1 -1
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/TestLanguageNameGrammarmaster+4 -1
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/QuizGamemaster+2 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/PollNYmaster+2 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/PictureGamemaster+3 -3
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/Athenamaster+5 -5
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/DataTransfermaster+5 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/FanBoxesmaster+3 -3
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/DidYouKnowmaster+1 -1
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/Commentsmaster+2 -2
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/PageFormsmaster+6 -6
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/SportsTeamsmaster+3 -3
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/SocialProfilemaster+4 -4
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/ConfirmAccountmaster+4 -4
Replace deprecated OutputPage::parse(), which will be removed from MWmediawiki/extensions/Formmaster+6 -3
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/PageFormsmaster+6 -4
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/Videomaster+13 -11
Remove most support for configuring Tidy, including Raggettmediawiki/coremaster+33 -562
Hard deprecate codepaths where tidy is disabledmediawiki/coremaster+13 -0
Replace deprecated OutputPage::parse()mediawiki/extensions/SecurePollmaster+3 -4
Replace deprecated OutputPage::parse()mediawiki/extensions/Translatemaster+74 -8
Deprecate OutputPage::parse() and OutputPage::parseInline()mediawiki/coreREL1_32+192 -28
Replace deprecated OutputPage::parse() in CollectionPageTemplatemediawiki/extensions/Collectionmaster+1 -1
Replace deprecated call to OutputPage::parse() in HTMLFormmediawiki/coremaster+1 -1
Replace deprecated OutputPage::parse()mediawiki/extensions/Collectionmaster+5 -5
Deprecate OutputPage::parse() and OutputPage::parseInline()mediawiki/coremaster+192 -28
Replace deprecated calls to OutputPage::parse()mediawiki/coremaster+42 -20
Replace deprecated OutputPage::parse()mediawiki/extensions/ConfirmEditmaster+1 -1
Replace deprecated OutputPage::parseInline()mediawiki/extensions/OAuthmaster+4 -4
Replace deprecated OutputPage::parse/parseInline()mediawiki/extensions/AbuseFiltermaster+5 -7
Replace deprecated OutputPage::parse()mediawiki/extensions/CodeReviewmaster+3 -3
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/ConfirmEditREL1_32+2 -2
Replace deprecated OutputPage::parse/parseInline()mediawiki/extensions/CentralAuthmaster+6 -8
Replace deprecated OutputPage::parse()mediawiki/extensions/TemplateSandboxmaster+10 -3
Replace deprecated OutputPage::parse()mediawiki/extensions/VipsScalermaster+4 -1
Replace deprecated OutputPage::parse()mediawiki/extensions/FlaggedRevsmaster+2 -2
Replace deprecated calls to OutputPage::parseInline()mediawiki/coremaster+9 -7
Replace deprecated OutputPage::parse/parseInline()mediawiki/extensions/LiquidThreadsmaster+12 -7
Replace deprecated OutputPage::parse()mediawiki/extensions/DonationInterfacemaster+11 -1
Avoid untidy calls to OutputPage::addWikiText()mediawiki/extensions/Translatemaster+47 -13
Hard deprecate non-tidy OutputPage::addWikiText() methodmediawiki/coremaster+9 -0
Tidy Message::parseAsBlock() by enabling tidy in MessageCachemediawiki/coremaster+5 -3
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/SecurePollmaster+9 -9
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/Cargomaster+23 -8
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/AdManagermaster+13 -13
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/SemanticGenealogymaster+16 -16
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/MOOCmaster+16 -13
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/examplesmaster+8 -5
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/CheckUsermaster+4 -5
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/WikiLexicalDatamaster+24 -24
Use OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()mediawiki/coremaster+58 -49
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/ConfirmEditmaster+2 -2
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/CollaborationKitmaster+2 -2
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/FundraiserLandingPagemaster+4 -1
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/MassMessagemaster+4 -2
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/MapSourcesmaster+9 -3
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/FlaggedRevsmaster+2 -2
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/ZeroPortalmaster+3 -3
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/Collectionmaster+4 -4
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/Mathmaster+5 -2
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/CentralAuthmaster+1 -1
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/CodeReviewmaster+5 -5
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/ArticlePlaceholdermaster+4 -4
Replace deprecated untidy OutputPage::addWikiText() methodmediawiki/extensions/CodeReviewmaster+5 -5
Replace deprecated OutputPage::addWikiText() methodmediawiki/extensions/Wikibasemaster+1 -1
Hard deprecate OutputPage::addWikiText*Tidy() methodsmediawiki/coremaster+4 -0
Update users of deprecated OutputPage::addWikiText*Tidy() methodsmediawiki/coremaster+3 -2
Hard deprecate unused OutputPage::addWikiText* methodsmediawiki/coremaster+30 -6
OutputPage::addWikiTextTidy() has been renamed to addWikiTextAsContent()mediawiki/extensions/ProofreadPagemaster+1 -1
Deprecate and rename OutputPage::addWikiText* methodsmediawiki/coremaster+172 -18
Avoid untidy call to OutputPage::addWikiMsg()mediawiki/extensions/Translatemaster+4 -5
Use Remex for TextContentTest subclassesmediawiki/coremaster+1 -1
Make maintenance/parse.php default to tidy outputmediawiki/coremaster+9 -5
Deprecate the 'disabletidy' parameter for ApiParsemediawiki/coremaster+10 -4
Use OutputPage::addWikiTextTidy() when text is in content languagemediawiki/extensions/ProofreadPagemaster+1 -1
Hard deprecate non-Remex tidy modesmediawiki/coremaster+10 -2
Soft deprecate non-Remex tidy configurationsmediawiki/coremaster+22 -3
Hard-deprecate the $wgUseTidy optionmediawiki/coremaster+20 -11
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jan 28 2020, 10:06 PM

Change 565146 merged by jenkins-bot:
[mediawiki/core@master] Update parserTests to v2 format (default html/php tests to tidy)

https://gerrit.wikimedia.org/r/565146

• ssastry triaged this task as Medium priority.Feb 27 2020, 1:11 AM
DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Mar 5 2020, 7:22 PM
hashar mentioned this in T248242: IABot/2.0 uses deprecated MediaWiki API calls.Mar 21 2020, 8:48 PM
cscott added a parent task: T248186: Prepare Parsoid for MediaWiki 1.35 LTS.Mar 23 2020, 3:32 PM
gerritbot added a comment.Apr 3 2020, 9:06 PM

Change 585330 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove codepaths which ran parser in 'untidy' mode

https://gerrit.wikimedia.org/r/585330

gerritbot added a comment.Apr 3 2020, 9:06 PM

Change 585331 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate ParserOptions::getTidy() and ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/585331

gerritbot added a comment.Apr 13 2020, 9:48 PM

Change 585330 merged by jenkins-bot:
[mediawiki/core@master] Remove codepaths which ran parser in 'untidy' mode

https://gerrit.wikimedia.org/r/585330

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Apr 13 2020, 10:00 PM
gerritbot added a comment.Apr 20 2020, 6:19 AM

Change 585331 merged by jenkins-bot:
[mediawiki/core@master] Deprecate ParserOptions::getTidy() and ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/585331

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 20 2020, 7:00 AM
cscott closed subtask T174199: Get rid of the non-Tidy option in parser tests as Resolved.May 1 2020, 9:03 PM
gerritbot added a comment.May 1 2020, 9:06 PM

Change 593825 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceSocial@master] Always tidy the parser output

https://gerrit.wikimedia.org/r/593825

gerritbot added a comment.May 1 2020, 9:09 PM

Change 593820 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate a few more tidy-related methods

https://gerrit.wikimedia.org/r/593820

gerritbot added a comment.May 1 2020, 9:09 PM

Change 593827 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceFoundation@master] Use MWTidy::tidy() directly

https://gerrit.wikimedia.org/r/593827

gerritbot added a comment.May 2 2020, 5:26 AM

Change 593879 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TextExtracts@master] Tidy is no longer configurable in MW 1.35

https://gerrit.wikimedia.org/r/593879

gerritbot added a comment.May 4 2020, 5:50 AM

Change 593827 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Use MWTidy::tidy() directly

https://gerrit.wikimedia.org/r/593827

gerritbot added a comment.May 4 2020, 12:38 PM

Change 593825 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSocial@master] Always tidy the parser output

https://gerrit.wikimedia.org/r/593825

gerritbot added a comment.May 8 2020, 10:32 PM

Change 593820 merged by jenkins-bot:
[mediawiki/core@master] Deprecate a few more tidy-related methods

https://gerrit.wikimedia.org/r/593820

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).May 8 2020, 11:00 PM
gerritbot added a comment.Jun 15 2020, 12:31 PM

Change 593879 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Tidy is no longer configurable in MW 1.35

https://gerrit.wikimedia.org/r/593879

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).Jun 15 2020, 1:00 PM
Jdforrester-WMF added a comment.Jun 29 2020, 2:16 PM

What's left to do here?

cscott added a comment.Jul 15 2020, 2:39 AM

Well, includes/parser/MWTidy.php still exists, along with a couple more of the deprecated-but-not-quite-removed things. I think as soon as 1.35 is branched (well, let's say "next week") we could actually remove those hard-deprecated bits in 1.36 and close out this task.

Here's a short list:

  • ParserBeforeTidy hook
  • includes/parser/MWTidy::singleton() (but pretty much the entire class)
  • ParserOptions::getTidy() / setTidy()
  • maintenance/benchmarks/benchmarkTidy.php (probably)
  • tests/parser/TestFileReader.php support for +untidy
  • tests/parser/editTests.php seems to have mentions of tidy as well
  • tests/parser/parserTests.php has some +tidy clauses which can be cleaned up since that's the default.
  • tests/phpunit/includes/OutputPageTest.php seems to have some untidy tests?
Legoktm edited projects, added MW-1.36-release; removed MW-1.35-release.Jul 15 2020, 4:29 AM
gerritbot added a comment.Aug 12 2020, 10:16 PM

Change 619861 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove ParserBeforeTidy hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/619861

gerritbot added a comment.Aug 12 2020, 10:16 PM

Change 619862 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove 'tidy' from ParserOptions

https://gerrit.wikimedia.org/r/619862

gerritbot added a comment.Aug 12 2020, 10:16 PM

Change 619863 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove all methods of MWTidy except for MWTidy::tidy()

https://gerrit.wikimedia.org/r/619863

gerritbot added a comment.Aug 13 2020, 3:38 AM

Change 619891 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Flow@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619891

gerritbot added a comment.Aug 13 2020, 3:41 AM

Change 619892 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/AbuseFilter@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619892

gerritbot added a comment.Aug 13 2020, 3:42 AM

Change 619893 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Echo@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619893

gerritbot added a comment.Aug 13 2020, 3:44 AM

Change 619894 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/UploadWizard@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619894

gerritbot added a comment.Aug 13 2020, 3:46 AM

Change 619895 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceFoundation@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619895

gerritbot added a comment.Aug 13 2020, 3:48 AM

Change 619896 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Comments@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619896

gerritbot added a comment.Aug 13 2020, 3:51 AM

Change 619897 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DocBookExport@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619897

gerritbot added a comment.Aug 13 2020, 3:52 AM

Change 619898 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VEForAll@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619898

gerritbot added a comment.Aug 13 2020, 10:14 AM

Change 619861 merged by jenkins-bot:
[mediawiki/core@master] Remove ParserBeforeTidy hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/619861

gerritbot added a comment.Aug 13 2020, 10:19 AM

Change 619891 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619891

gerritbot added a comment.Aug 13 2020, 10:19 AM

Change 619892 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619892

gerritbot added a comment.Aug 13 2020, 10:19 AM

Change 619893 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619893

gerritbot added a comment.Aug 13 2020, 10:19 AM

Change 619894 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619894

gerritbot added a comment.Aug 13 2020, 10:20 AM

Change 619862 merged by jenkins-bot:
[mediawiki/core@master] Remove 'tidy' from ParserOptions

https://gerrit.wikimedia.org/r/619862

gerritbot added a comment.Aug 13 2020, 10:20 AM

Change 619896 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619896

gerritbot added a comment.Aug 13 2020, 10:20 AM

Change 619897 merged by jenkins-bot:
[mediawiki/extensions/DocBookExport@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619897

gerritbot added a comment.Aug 13 2020, 10:20 AM

Change 619898 merged by jenkins-bot:
[mediawiki/extensions/VEForAll@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619898

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 13 2020, 11:00 AM
gerritbot added a comment.Aug 15 2020, 2:33 PM

Change 619895 merged by Robert Vogel:
[mediawiki/extensions/BlueSpiceFoundation@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/619895

gerritbot added a comment.Aug 15 2020, 2:33 PM

Change 620457 had a related patch set uploaded (by Robert Vogel; owner: C. Scott Ananian):
[mediawiki/extensions/BlueSpiceFoundation@REL1_35] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/620457

gerritbot added a comment.Aug 15 2020, 2:34 PM

Change 620457 merged by Robert Vogel:
[mediawiki/extensions/BlueSpiceFoundation@REL1_35] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/620457

gerritbot added a comment.Aug 17 2020, 6:38 PM

Change 619863 merged by jenkins-bot:
[mediawiki/core@master] Remove all methods of MWTidy except for MWTidy::tidy()

https://gerrit.wikimedia.org/r/619863

Umherirrender subscribed.Aug 22 2020, 8:37 PM

ParserMigration is still using \MWTidy::factory and now failing

Jdforrester-WMF added a comment.Aug 24 2020, 10:57 AM
In T198214#6404139, @Umherirrender wrote:

ParserMigration is still using \MWTidy::factory and now failing

Yeah, if that code ever gets un-abandoned there'll be a bunch of fixes we'll need to do.

Pppery subscribed.Aug 26 2020, 1:44 PM

T250936: Archive the ParserMigration extension

cscott added a comment.Aug 26 2020, 4:47 PM

Still left:

In T198214#6307081, @cscott wrote:
  • ParserOptions::setTidy() (deprecated in 1.36, needs to be removed in 1.37)
  • maintenance/benchmarks/benchmarkTidy.php (probably)
  • tests/parser/editTests.php seems to have mentions of tidy as well
  • tests/parser/parserTests.php has some +tidy clauses (and +untidy) which can be cleaned up

Moving to "things to do before 1.36" task.

cscott edited parent tasks, added: T261329: Prepare Parsoid for MW; removed: T248186: Prepare Parsoid for MediaWiki 1.35 LTS.Aug 26 2020, 4:48 PM
Pppery unsubscribed.Aug 26 2020, 5:00 PM
gerritbot added a comment.Oct 28 2020, 7:10 PM

Change 565116 merged by jenkins-bot:
[mediawiki/extensions/FundraisingEmailUnsubscribe@master] Replace deprecated OutputPage::parse(), which will be removed from MW

https://gerrit.wikimedia.org/r/565116

gerritbot added a comment.Nov 11 2020, 10:57 AM

Change 565123 abandoned by Duncancrane:
[mediawiki/extensions/TinyMCE@master] Replace deprecated OutputPage::parse(), which will be removed from MW

Reason:
This has been achieved by another patch

https://gerrit.wikimedia.org/r/565123

gerritbot added a comment.Feb 18 2021, 10:09 PM

Change 665128 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate MWTidy and TidyDriverBase::supportsValidate()

https://gerrit.wikimedia.org/r/665128

Umherirrender unsubscribed.Feb 27 2021, 10:06 PM
gerritbot added a comment.Mar 16 2021, 8:29 PM

Change 665128 merged by jenkins-bot:
[mediawiki/core@master] Deprecate MWTidy and TidyDriverBase::supportsValidate()

https://gerrit.wikimedia.org/r/665128

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Mar 16 2021, 9:00 PM
Jdforrester-WMF added a comment.Apr 10 2021, 10:43 PM

Hey there, should this be moved to 1.37? The cut for 1.36 has happened, and 1.36.0-rc.0 will be cut in a fortnight or so, after which feature changes shouldn't be landed and back-ported.

Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.36-release board.Apr 15 2021, 6:23 PM
Jdforrester-WMF removed a project: MW-1.36-release.Apr 21 2021, 6:39 PM
• ssastry added a comment.Sep 29 2021, 3:17 AM

Anything else left here? Looks like all dependent subtasks are resolved.

Restricted Application added a project: Parsoid. · View Herald TranscriptSep 29 2021, 3:17 AM
cscott added a comment.Sep 29 2021, 4:46 PM

I think the last thing to do is actually to remove some of the methods which were deprecated in 1.35/1.36, like ParserOptions::setTidy().

I think this is still the list, and yes @Jdforrester-WMF we should do this in 1.37.

In T198214#6413428, @cscott wrote:

Still left:

In T198214#6307081, @cscott wrote:
  • ParserOptions::setTidy() (deprecated in 1.36, needs to be removed in 1.37)
  • maintenance/benchmarks/benchmarkTidy.php (probably)
  • tests/parser/editTests.php seems to have mentions of tidy as well
  • tests/parser/parserTests.php has some +tidy clauses (and +untidy) which can be cleaned up

Moving to "things to do before 1.36" task.

gerritbot added a comment.Sep 30 2021, 6:27 PM

Change 725077 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Get rid of +untidy tests

https://gerrit.wikimedia.org/r/725077

gerritbot added a comment.Sep 30 2021, 6:40 PM

Change 725079 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Get rid of +tidy reference in parser tests

https://gerrit.wikimedia.org/r/725079

gerritbot added a comment.Sep 30 2021, 6:45 PM

Change 725082 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Get rid of +tidy, +untidy references from parser tests

https://gerrit.wikimedia.org/r/725082

gerritbot added a comment.Sep 30 2021, 6:46 PM

Change 725083 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/InputBox@master] Get rid of +tidy references from parser tests

https://gerrit.wikimedia.org/r/725083

gerritbot added a comment.Sep 30 2021, 6:48 PM

Change 725087 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/WikiSEO@master] Get rid of +tidy references from parser tests

https://gerrit.wikimedia.org/r/725087

gerritbot added a comment.Sep 30 2021, 6:54 PM

Change 725081 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/ChessBrowser@master] Get rid of +tidy references from parser tests

https://gerrit.wikimedia.org/r/725081

gerritbot added a comment.Sep 30 2021, 7:44 PM

Change 725077 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Get rid of +untidy tests

https://gerrit.wikimedia.org/r/725077

gerritbot added a comment.Sep 30 2021, 7:45 PM

Change 725079 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Get rid of +tidy reference in parser tests

https://gerrit.wikimedia.org/r/725079

Arlolra moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Sep 30 2021, 8:23 PM
gerritbot added a comment.Sep 30 2021, 8:52 PM

Change 725087 merged by jenkins-bot:

[mediawiki/extensions/WikiSEO@master] Get rid of +tidy references from parser tests

https://gerrit.wikimedia.org/r/725087

gerritbot added a comment.Sep 30 2021, 8:52 PM

Change 725082 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Get rid of +tidy, +untidy references from parser tests

https://gerrit.wikimedia.org/r/725082

gerritbot added a comment.Sep 30 2021, 8:55 PM

Change 725081 merged by jenkins-bot:

[mediawiki/extensions/ChessBrowser@master] Get rid of +tidy references from parser tests

https://gerrit.wikimedia.org/r/725081

• ssastry mentioned this in rECHBb115881b0c3b: Get rid of +tidy references from parser tests.Sep 30 2021, 8:55 PM
• ssastry mentioned this in rEWSEcbfb880aba7d: Get rid of +tidy references from parser tests.
gerritbot added a comment.Sep 30 2021, 9:28 PM

Change 725083 merged by jenkins-bot:

[mediawiki/extensions/InputBox@master] Get rid of +tidy references from parser tests

https://gerrit.wikimedia.org/r/725083

gerritbot added a comment.Sep 30 2021, 9:33 PM

Change 725116 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Start hard deprecating +tidy uses in parser test files

https://gerrit.wikimedia.org/r/725116

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 1 2021, 5:21 PM
gerritbot added a comment.Oct 1 2021, 8:54 PM

Change 725116 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Start hard deprecating +tidy uses in parser test files

https://gerrit.wikimedia.org/r/725116

gerritbot added a comment.Oct 7 2021, 8:14 PM

Change 727513 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] Get rid of ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/727513

gerritbot added a comment.Oct 7 2021, 8:24 PM

Change 727516 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] Tweak Tidy handling in editTests.php

https://gerrit.wikimedia.org/r/727516

• ssastry added a comment.Oct 7 2021, 8:24 PM

I think once those patches merge, we can bid this task goodbye.

gerritbot added a comment.Oct 7 2021, 9:52 PM

Change 727513 merged by jenkins-bot:

[mediawiki/core@master] Get rid of ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/727513

gerritbot added a comment.Oct 7 2021, 9:57 PM

Change 727516 merged by jenkins-bot:

[mediawiki/core@master] Tweak Tidy handling in editTests.php

https://gerrit.wikimedia.org/r/727516

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 7 2021, 10:00 PM
• ssastry closed this task as Resolved.Oct 7 2021, 10:06 PM
Jdforrester-WMF added a comment.Oct 7 2021, 10:11 PM

Hurrah!

gerritbot added a comment.Oct 24 2021, 12:36 PM

Change 733748 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ParserMigration@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/733748

gerritbot added a comment.Oct 24 2021, 4:50 PM

Change 733748 merged by jenkins-bot:

[mediawiki/extensions/ParserMigration@master] Remove calls to ParserOptions::setTidy()

https://gerrit.wikimedia.org/r/733748

Octfx mentioned this in rEWSE6a6ad2ec6131: refactor: Add declare strict_types.Dec 27 2022, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits