In gerrit:570042 we introduced a ConfigRegistry for wikispeech and started using Config objects rather than requesting wg globals.
As a result the codebase contains a mixture of global wg... and Config objects. It's desirable to switch over to the later.
We probably still want to unify on either approach but are in no need of doing so until a new recommendation is out.
We use globals in two places. We should use the latest recommendations on the page linked in the description. This is not ConfigRegistry, which we don't use.
So for example, theese two places are in DefaultUserOptions.php and UtteranceStore.php (what I can see):
Instead of:
global $wgUploadDirectory;
We could do:
$this->config->get( 'UploadDirectory' )
?
That should work in UtteranceStore where we have a config. In DefaultUserOptions you have to you have to get it some other way, probably through MediaWikiServices.