Update `NYTPhotoViewer` framework to guard against deprecated frameworks
Open, MediumPublic
Actions

Assigned To

None

Authored By

	• Dmantena
	Apr 2 2020, 9:08 PM

Description

Our fullscreen photo gallery and animated image support are powered by a fork of NYTPhotoViewer and its nested dependency FLAnimatedImage. FLAnimatedImage is no longer actively maintained, so as of NYTPhotoViewer 4.0.0 their team has replaced it with Pinterest's PINRemoteImage to resolve build issues they were encountering.

If PINRemoteImage supports our needs, we should update our version of NYTPhotoViewer and replace our use/internal extensions of FLAnimatedImage with PINRemoteImage to protect us against running into issues like the NYT team faced. Additionally, as @JoeWalsh suggested, may also be worth investigating if NYTPhotoViewer has addressed the issues we forked it for and if not try and PR our changes upstream.

This is not a critical task, but feels like it would fit naturally into the period of time when iOS 14 is available in beta/we evaluate minimum iOS requirements (currently the app's minimum deployment target is iOS 11.0).

Event Timeline

• Dmantena created this task.Apr 2 2020, 9:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 9:08 PM

LGoto triaged this task as Low priority.Apr 6 2020, 6:43 PM

LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

LGoto added a project: iOS-app-v6.7-Bonefish-On-A-Bus.

LGoto edited projects, added iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat; removed iOS-app-v6.7-Bonefish-On-A-Bus.Jun 18 2020, 7:46 PM

LGoto edited projects, added iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower; removed iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat.Sep 22 2020, 8:15 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Sep 28 2020, 9:46 PM

@Tsevener What do you think about pushing this to a future release?

@Dmantena that sounds fine to me - I think something to look out for is when NYTPhotoViewer supports SPM (there's a pull request out for it now). Then we could both update it and chip away at Carthage at the same time.

Tsevener removed a project: iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower.Dec 8 2020, 8:29 PM

Been looking into this today. For posterity, the changes we've made to NYTPhotoViewer that we need to retain:

Allow status bar to remain visible: https://github.com/wikimedia/NYTPhotoViewer/commit/e4f7fd5f4ab4d117f0b78a83857d7eae88ad3942
Allow sharing of animated GIFs: Phab task and main work and update to code and more code (doesn't seem like this is upstream yet, but PR would be welcomed: https://github.com/nytimes/NYTPhotoViewer/issues/69)

Changes we made, that we no longer need to retain (as they've been fixed upstream):

Add iPhone X support: https://github.com/wikimedia/NYTPhotoViewer/commit/e1b96a2ffbfa328721e7364a3112e623d2762fa0 and https://github.com/wikimedia/NYTPhotoViewer/commit/26be6ffcac6fd48307db3dc28ddf609e349b89f1

So it seems like that specific route to sharing animated GIFs is broken in the current live version of the app. Not going to worry about fixing it for now, as it is such a corner case. (Also it silently fails - a long press on an animated GIF does nothing, rather than having some bad outcome.)

PR is up: https://github.com/wikimedia/wikipedia-ios/pull/3812/

Status bar visible should maybe be upstream. Looks like there is currently a PR for that: https://github.com/nytimes/NYTPhotoViewer/pull/336

On hold as we track these upstream PRs and issues:

LGoto triaged this task as Medium priority.Sep 28 2021, 8:47 PM

LGoto added a project: iOS-app-v6.9.1-Carp-On-A-Moon-Lander.

LGoto removed a project: iOS-app-v6.9.1-Carp-On-A-Moon-Lander.Apr 26 2022, 8:30 PM

Update `NYTPhotoViewer` framework to guard against deprecated frameworksOpen, MediumPublicActions

Description

Event Timeline

Update `NYTPhotoViewer` framework to guard against deprecated frameworks
Open, MediumPublic
Actions