Following-on from T204176: Decide how to configure ESLint rules and ignores where we decided this was the pattern we wanted to adopt.
Not sure if this is #LibUp-able.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 591982 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] build: Move eslint ignores to .eslintignore
Comment Actions
Change 591982 merged by jenkins-bot:
[mediawiki/core@master] build: Move eslint ignores to .eslintignore
Comment Actions
Repeating from https://phabricator.wikimedia.org/T204176#6620135, we should probably wait for the new ESLintConfig…
Comment Actions
Change 713026 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/extensions/PageTriage@master] build: Improve eslint config to be simpler and IDE/CLI discoverable
Comment Actions
Change 713026 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] build: Improve eslint config to be simpler and IDE/CLI discoverable
Comment Actions
Change 837164 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/extensions/ProofreadPage@master] modules: Rename internal foreign/ dir to lib/
Comment Actions
Change 837164 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] modules: Rename internal foreign/ dir to lib/
Comment Actions
The use of .eslintignore is documented as deprecated - https://eslint.org/docs/latest/use/configure/ignore-deprecated
Should this task changed to Declined? A new decision could be in a new task (or part of T267941)
Comment Actions
Only deprecated for eslint 9. The other locations are also deprecated, I believe.
A new decision could be in a new task (or part of T267941)
Yes, that's a part of the eslint 9 migration. We should probably make a task for all the different bits.
Comment Actions
When the task stays open it seems valid to do the migration to .eslintignore now, but the question is, if the effort is good enough to bind the review time and CI time to do it, when the migration to eslint 9 would not benefit from such a migration (because it uses another file and structure). It seems not the case, that why I suggest to decline the task.