Page MenuHomePhabricator

Move eslint ignores out of Gruntfile.js or package.json and into .eslintignore for all repos
Open, Needs TriagePublic

Description

Following-on from T204176: Decide how to configure ESLint rules and ignores where we decided this was the pattern we wanted to adopt.

Not sure if this is #LibUp-able.

Event Timeline

Change 591982 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] build: Move eslint ignores to .eslintignore

https://gerrit.wikimedia.org/r/591982

Change 591982 merged by jenkins-bot:
[mediawiki/core@master] build: Move eslint ignores to .eslintignore

https://gerrit.wikimedia.org/r/591982

Repeating from https://phabricator.wikimedia.org/T204176#6620135, we should probably wait for the new ESLintConfig…

Change 713026 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/PageTriage@master] build: Improve eslint config to be simpler and IDE/CLI discoverable

https://gerrit.wikimedia.org/r/713026

Change 713026 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] build: Improve eslint config to be simpler and IDE/CLI discoverable

https://gerrit.wikimedia.org/r/713026

Change 837164 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/ProofreadPage@master] modules: Rename internal foreign/ dir to lib/

https://gerrit.wikimedia.org/r/837164

Change 837164 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] modules: Rename internal foreign/ dir to lib/

https://gerrit.wikimedia.org/r/837164

The use of .eslintignore is documented as deprecated - https://eslint.org/docs/latest/use/configure/ignore-deprecated

Should this task changed to Declined? A new decision could be in a new task (or part of T267941)

The use of .eslintignore is documented as deprecated - https://eslint.org/docs/latest/use/configure/ignore-deprecated

Should this task changed to Declined?

Only deprecated for eslint 9. The other locations are also deprecated, I believe.

A new decision could be in a new task (or part of T267941)

Yes, that's a part of the eslint 9 migration. We should probably make a task for all the different bits.