Page MenuHomePhabricator
Create Task
Maniphest T250417

Deprecate and remove SquidPurgeClient classes
Closed, ResolvedPublic
Actions

Description

The SquidPurgeClient and SquidPurgeClientPool classes are obsolete. Internal usage should be replaced by MultiHttpClient.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+2 -516Remove SquidPurgeClient classes
mediawiki/coremaster+61 -36Migrate CdnCacheUpdate to MultiHttpClient and deprecate SquidPurgeClient
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Apr 16 2020, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2020, 5:26 PM
gerritbot added a comment.Apr 16 2020, 5:26 PM

Change 535993 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] Migrate CdnCacheUpdate to MultiHttpClient and remove SquidPurgeClient classes

https://gerrit.wikimedia.org/r/535993

gerritbot added a project: Patch-For-Review.Apr 16 2020, 5:26 PM
Krinkle moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Apr 16 2020, 5:26 PM
Krinkle moved this task from Library to HTTP Cache on the MediaWiki-libs-ObjectCache board.Apr 16 2020, 8:14 PM
• Gilles assigned this task to aaron.Apr 20 2020, 12:00 PM
• Gilles moved this task from Inbox to Doing (old) on the Performance-Team board.
gerritbot added a comment.Apr 20 2020, 4:18 PM

Change 535993 merged by jenkins-bot:
[mediawiki/core@master] Migrate CdnCacheUpdate to MultiHttpClient and deprecate SquidPurgeClient

https://gerrit.wikimedia.org/r/535993

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 20 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 20 2020, 5:10 PM
Krinkle triaged this task as Low priority.Apr 21 2020, 5:52 PM
Krinkle removed aaron as the assignee of this task.EditedMay 13 2020, 11:40 PM
Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.

Awaiting the MW 1.36 cycle for the next step.

taavi moved this task from Blocked (old) to Inbox on the Performance-Team board.Dec 29 2020, 2:21 PM
taavi added a subscriber: taavi.

1.36 cycle is now on-going. What would be the next step? Those classes aren't @newable and have no known uses. Do they need to be hard deprecated or can they just be removed?

dpifke moved this task from Inbox to Doing (old) on the Performance-Team board.Jan 4 2021, 7:10 PM
aaron added a comment.Jan 4 2021, 10:59 PM

See also: T264735

gerritbot added a comment.Jan 4 2021, 11:08 PM

Change 654324 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Remove SquidPurgeClient classes

https://gerrit.wikimedia.org/r/654324

gerritbot added a project: Patch-For-Review.Jan 4 2021, 11:08 PM
gerritbot added a comment.Jan 5 2021, 12:46 AM

Change 654324 merged by jenkins-bot:
[mediawiki/core@master] Remove SquidPurgeClient classes

https://gerrit.wikimedia.org/r/654324

Krinkle closed this task as Resolved.Jan 5 2021, 12:48 AM
Krinkle assigned this task to aaron.
Krinkle edited projects, added MW-1.36-release; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 5 2021, 1:00 AM
ineffyble mentioned this in T291768: CdnCacheUpdate defaults to port 1080 on MediaWiki >= 1.35.Sep 26 2021, 5:15 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL