Page MenuHomePhabricator

Deprecate and remove ParserAfterStrip
Open, Needs TriagePublic

Description

ParserAfterStrip and ParserBeforeStrip are now run back-to-back. Only one is needed. ParserAfterStrip isn't used by anything deployed by WMF, so let's kill that one.

Event Timeline

Change 446984 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/446984

Did you look at non-WMF use cases (via code search -- since that is the extent of what we are committed to looking at)? We cannot deprecate only on the basis of what is deployed on the cluster.

Yes, the patch contains both code searches.

In general I try to patch up even undeployed users. In this case there is no loss of functionality at all, the combination of ParserBeforeInternalParse and ParserBeforePreprocess runs at exactly the same time(s) that ParserBeforeStrip/ParserAfterStrip would.

Change 589683 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589683

Change 589685 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589685

Change 589686 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589686

Change 589689 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589689

Change 589690 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589690

Change 589691 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589691

Change 589683 merged by jenkins-bot:
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589683

Change 589686 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589686

Change 589689 merged by jenkins-bot:
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589689

Change 589690 merged by jenkins-bot:
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589690

Change 589691 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589691

Change 622618 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove ParserBeforeStrip/ParserAfterStrip hooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/622618

Change 589685 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589685

Change 628587 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628587

Change 446984 abandoned by Jforrester:
[mediawiki/core@master] Deprecate ParserBeforeStrip/ParserAfterStrip hooks

Reason:
New hook system meant that I did 4a77e850509b5f4b78b66ef9602577e1acc23245 instead.

https://gerrit.wikimedia.org/r/446984

Change 628587 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628587

Change 628557 had a related patch set uploaded (by Ammarpad; owner: Jforrester):
[mediawiki/core@REL1_35] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628557

Change 628557 merged by jenkins-bot:
[mediawiki/core@REL1_35] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628557

Change 622618 merged by jenkins-bot:
[mediawiki/core@master] Remove ParserBeforeStrip/ParserAfterStrip hooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/622618