ParserAfterStrip and ParserBeforeStrip are now run back-to-back. Only one is needed. ParserAfterStrip isn't used by anything deployed by WMF, so let's kill that one.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T261329 Prepare Parsoid for MW | |||
| Open | None | T236809 Refactor Parser.php to allow alternate parser (Parsoid) | |||
| Resolved | None | T250449 Deprecate and remove ParserAfterStrip |
Event Timeline
Comment Actions
Change 446984 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate ParserBeforeStrip/ParserAfterStrip hooks
Comment Actions
Did you look at non-WMF use cases (via code search -- since that is the extent of what we are committed to looking at)? We cannot deprecate only on the basis of what is deployed on the cluster.
Comment Actions
In general I try to patch up even undeployed users. In this case there is no loss of functionality at all, the combination of ParserBeforeInternalParse and ParserBeforePreprocess runs at exactly the same time(s) that ParserBeforeStrip/ParserAfterStrip would.
Comment Actions
Change 589683 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589685 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589686 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589689 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589690 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589691 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589683 merged by jenkins-bot:
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589686 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589689 merged by jenkins-bot:
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589690 merged by jenkins-bot:
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 589691 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 622618 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove ParserBeforeStrip/ParserAfterStrip hooks, deprecated in 1.35
Comment Actions
Change 589685 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 628587 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks
Comment Actions
Change 446984 abandoned by Jforrester:
[mediawiki/core@master] Deprecate ParserBeforeStrip/ParserAfterStrip hooks
Reason:
New hook system meant that I did 4a77e850509b5f4b78b66ef9602577e1acc23245 instead.
Comment Actions
Change 628587 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks
Comment Actions
Change 628557 had a related patch set uploaded (by Ammarpad; owner: Jforrester):
[mediawiki/core@REL1_35] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks
Comment Actions
Change 628557 merged by jenkins-bot:
[mediawiki/core@REL1_35] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks
Comment Actions
Change 622618 merged by jenkins-bot:
[mediawiki/core@master] Remove ParserBeforeStrip/ParserAfterStrip hooks, deprecated in 1.35
Comment Actions
Change 674120 had a related patch set uploaded (by Cicalese; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@REL1_35] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Change 674120 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@REL1_35] Don't use deprecated ParserBeforeStrip hook
Comment Actions
Per https://www.mediawiki.org/wiki/Manual:Hooks/ParserAfterStrip, "This feature was removed completely in version 1.36.0 (after being deprecated in 1.14.0). "