Page MenuHomePhabricator

wmde / WikibaseCodeSniffer tests fail on master
Closed, ResolvedPublic

Description

There is no CI on the github repo for wmde/WikibaseCodeSniffer
As a result some of the most recent updates broken the "composer test" command.

Either we should:

  • Fix the tests on master (and continue using this seperate set of sniffs)
  • Stop using wmde/WikibaseCodeSniffer and instead just use mediawiki/codesniffer directly from upstream

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Stop using wmde/WikibaseCodeSniffer and instead just use mediawiki/codesniffer directly from upstream

Appears to already be in progress at T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - can this be closed?

Umherirrender subscribed.

Most work is done: T266823

More should be done on the issue tracker on github if needed