Page MenuHomePhabricator
Create Task
Maniphest T251045

Invalid titles cause an TypeError: "mwTitle is null" when looking for a signature in a comment
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Add a comment with an external link to a wikipage with an illegal character (here it is |): [https://fr.wikipedia.org/wiki/MediaWiki| Test].
  2. Save the comment.
  3. Refresh the page.
  4. Yay the TypeError!

In this case, title = getPageTitleFromUri( "https://fr.wikipedia.org/wiki/MediaWiki|" ) returns MediaWiki| and mwTitle = mw.Title.newFromText( title ) returns null.

The very first check on the title causes the TypeError.

Here an example. Can be reproduced with an external link to any edition (e.g: [https://en.wikipedia.org/wiki/MediaWiki| Test]). I hope it's complete, I just ran into it by coincidence.

Details

SubjectRepoBranchLines +/-
parser: Don't crash on links to invalid titlesmediawiki/extensions/DiscussionToolsmaster+3 -0
Customize query in gerrit

Event Timeline

Lofhi created this task.Apr 25 2020, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2020, 9:45 PM
Lofhi updated the task description. (Show Details)Apr 25 2020, 9:46 PM
Lofhi updated the task description. (Show Details)
Lofhi updated the task description. (Show Details)Apr 25 2020, 9:48 PM
Fralambert awarded a token.Apr 27 2020, 1:48 PM
Fralambert rescinded a token.
Fralambert awarded a token.
ppelberg added a project: OWC2020 (OWC2020 Replying 1.0).Apr 27 2020, 3:55 PM
matmarex claimed this task.Apr 27 2020, 5:47 PM
matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).
gerritbot added a comment.Apr 27 2020, 5:59 PM

Change 592727 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] parser: Don't crash on links to invalid titles

https://gerrit.wikimedia.org/r/592727

gerritbot added a project: Patch-For-Review.Apr 27 2020, 5:59 PM
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 27 2020, 5:59 PM

Thanks for reporting this!

gerritbot added a comment.Apr 27 2020, 6:53 PM

Change 592727 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] parser: Don't crash on links to invalid titles

https://gerrit.wikimedia.org/r/592727

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2020, 7:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 27 2020, 8:08 PM
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 8:00 AM
Ryasmeen edited projects, added Verified; removed Editing QA.May 26 2020, 8:33 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.May 26 2020, 8:39 PM
ppelberg closed this task as Resolved.Jun 1 2020, 1:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL