Too many requests to load very simple main page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sergiidumyk
	May 4 2020, 5:14 PM

Description

Hello, my wiki is very simple but it takes 59 requests to load the main page. I believe I did most of the optimizations. Main English Wikipedia is 37 requests, to compare. Any clues where to check?

Screen Shot 2020-05-04 at 8.01.30 PM.png (1×2 px, 744 KB)

Details

	Subject	Repo	Branch	Lines +/-
	resourceloader: Let wgResourceLoaderMaxQueryLength=-1 fallback to default	mediawiki/core	REL1_34	+23 -7
	resourceloader: Let wgResourceLoaderMaxQueryLength=-1 fallback to default	mediawiki/core	master	+23 -7

Customize query in gerrit

Related Objects

Mentioned Here: rMW3ac385a0c39a: resourceloader: Drop support for low Suhosin 'max_value_length' values

Event Timeline

Sergiidumyk created this task.May 4 2020, 5:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2020, 5:14 PM

Krinkle added a project: MediaWiki-ResourceLoader.May 4 2020, 5:17 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 4 2020, 5:17 PM

When you open the page in a browser and then check the Developer Tools' Network panel, I see many separate load.php requests. One for each module.

Looking at the value of mw.loader.maxQueryLength I see this is set to -1. Be sure to remove any setting related to that from LocalSettings.php. https://www.mediawiki.org/wiki/Manual:$wgResourceLoaderMaxQueryLength

Now just 12 requests! You guys are awesome!!

Sergiidumyk closed this task as Resolved.May 4 2020, 6:01 PM

Sergiidumyk claimed this task.

Change 594296 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Let wgResourceLoaderMaxQueryLength=-1 fallback to default

https://gerrit.wikimedia.org/r/594296

gerritbot added a project: Patch-For-Review.May 4 2020, 8:41 PM

Reopening as a patch by @Krinkle is pending.

So is there any more improvements I can get after the patch? Or is the patch just about enforcing what I had to fix?

In T251789#6107989, @Sergiidumyk wrote:

So is there any more improvements I can get after the patch? Or is the patch just about enforcing what I had to fix?

It's trying to prevent this error happening for other people by treating -1 (which the MW installer was setting at some point) as 0, but infact, a sensible value

The patch won't make any further difference to your wiki

Change 594296 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Let wgResourceLoaderMaxQueryLength=-1 fallback to default

https://gerrit.wikimedia.org/r/594296

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 8 2020, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 8 2020, 1:10 AM

Is there anything left to do on this task, now that this patch has been merged?

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.May 12 2020, 7:26 AM

Probably just backporting?

Change 595992 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_34] resourceloader: Let wgResourceLoaderMaxQueryLength=-1 fallback to default

https://gerrit.wikimedia.org/r/595992

gerritbot added a project: Patch-For-Review.May 12 2020, 5:19 PM

Krinkle triaged this task as Low priority.May 12 2020, 5:20 PM

Change 595992 merged by jenkins-bot:
[mediawiki/core@REL1_34] resourceloader: Let wgResourceLoaderMaxQueryLength=-1 fallback to default

https://gerrit.wikimedia.org/r/595992

Krinkle closed this task as Resolved.May 12 2020, 5:56 PM

ReleaseTaggerBot added a project: MW-1.34-notes.May 12 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 6:10 PM