Page MenuHomePhabricator
Create Task
Maniphest T252056

Regression: No page curation AfD log entries after 10 October 2019, and AfD nomination edit summary includes an empty string in parentheses
Closed, ResolvedPublic
Actions

Description

In the deletion tag log, I noticed that there are no page curation AfD log entries after 10 October 2019. Also, perhaps related to this, when a page is nominated for AfD using the page curation toolbar, the edit summary for the edit adding the AfD tag to the page says "Nominated page for deletion using Page Curation ()" with an empty string in parentheses instead of "Nominated page for deletion using Page Curation (afd)".

Two examples to illustrate this bug:

Details

SubjectRepoBranchLines +/-
delete.js: Add nomination tag alwaysmediawiki/extensions/PageTriagemaster+1 -1
Customize query in gerrit

Event Timeline

GTrang created this task.May 6 2020, 6:51 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 6 2020, 6:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
GTrang renamed this task from No page curation AfD log entries after 10 October 2019, and AfD nomination edit summary includes an empty string in parentheses to Regression: No page curation AfD log entries after 10 October 2019, and AfD nomination edit summary includes an empty string in parentheses.Mar 20 2022, 12:31 AM
GTrang added a project: Regression.
Ammarpad subscribed.Mar 20 2022, 11:43 AM

The empty parentheses are supposed to contain the nomination tag list, apparently empty list is sent to the API, but the parentheses are hard-corded in the message already.

Ammarpad changed the task status from Open to In Progress.Mar 20 2022, 11:58 AM

This is probably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/535725 which was merged October 7, 2019, and reached enwiki October 10, which is the exact day the issue started.

gerritbot added a comment.Mar 20 2022, 1:25 PM

Change 772016 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/PageTriage@master] delete.js: Add nomination tag always

https://gerrit.wikimedia.org/r/772016

gerritbot added a project: Patch-For-Review.Mar 20 2022, 1:25 PM
Ammarpad claimed this task.Mar 20 2022, 7:04 PM
gerritbot added a comment.Mar 23 2022, 11:40 AM

Change 772016 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] delete.js: Add nomination tag always

https://gerrit.wikimedia.org/r/772016

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 23 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 12:10 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team-Filtering, Growth-Team.Mar 24 2022, 8:34 AM
kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova closed this task as Resolved.Mar 29 2022, 11:57 PM
Etonkovidova subscribed.

Checked

  • Special:Log/pagetriage-deletion - the list shows the most recent entries
  • checked for the nomination tag present - e.g. Nominated page for deletion using Page Curation (subst:blp-prod)
  • checked for the AfD workflow on testwiki (for regression) - all seem to be working as expected.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits