Page MenuHomePhabricator

Fixup SQLite INSERT INTO table_tmp SELECT * FROM table
Open, Needs TriagePublic

Description

Follows up T202211 and rMWe90012d55818: Fix SQLite patch-(page|template)links-fix-pk.sql column order

We should tidy these up more widely

initial-indexes.sql:INSERT OR IGNORE INTO /*_*/user_tmp SELECT * FROM /*_*/user;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/user_groups_tmp SELECT * FROM /*_*/user_groups;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/page_tmp SELECT * FROM /*_*/page;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/revision_tmp SELECT * FROM /*_*/revision;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/pagelinks_tmp SELECT * FROM /*_*/pagelinks;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/templatelinks_tmp SELECT * FROM /*_*/templatelinks;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/imagelinks_tmp SELECT * FROM /*_*/imagelinks;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/categorylinks_tmp SELECT * FROM /*_*/categorylinks;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/category_tmp SELECT * FROM /*_*/category;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/langlinks_tmp SELECT * FROM /*_*/langlinks;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/site_stats_tmp SELECT * FROM /*_*/site_stats;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/ipblocks_tmp SELECT * FROM /*_*/ipblocks;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/watchlist_tmp SELECT * FROM /*_*/watchlist;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/math_tmp SELECT * FROM /*_*/math;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/interwiki_tmp SELECT * FROM /*_*/interwiki;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/page_restrictions_tmp SELECT * FROM /*_*/page_restrictions;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/protected_titles_tmp SELECT * FROM /*_*/protected_titles;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/page_props_tmp SELECT * FROM /*_*/page_props;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/archive_tmp SELECT * FROM /*_*/archive;
initial-indexes.sql:INSERT OR IGNORE INTO /*_*/externallinks_tmp SELECT * FROM /*_*/externallinks;

Done:

patch-categorylinks-fix-pk.sql:	SELECT *
patch-interwiki-fix-pk.sql:	SELECT * FROM /*_*/interwiki;
patch-iwlinks-fix-pk.sql:	SELECT * FROM /*_*/iwlinks;
patch-langlinks-fix-pk.sql:	SELECT * FROM /*_*/langlinks;
patch-log_search-fix-pk.sql:	SELECT * FROM /*_*/log_search;
patch-module_deps-fix-pk.sql:	SELECT * FROM /*_*/module_deps;
patch-objectcache-fix-pk.sql:	SELECT * FROM /*_*/objectcache;
patch-page_props-fix-pk.sql:	SELECT * FROM /*_*/page_props;
patch-protected_titles-fix-pk.sql:	SELECT * FROM /*_*/protected_titles;
patch-querycache_info-fix-pk.sql:	SELECT * FROM /*_*/querycache_info;
patch-site_stats-fix-pk.sql:	SELECT * FROM /*_*/site_stats;
patch-text-fix-pk.sql:	SELECT * FROM /*_*/text;
patch-user_former_groups-fix-pk.sql:	SELECT * FROM /*_*/user_former_groups;
patch-user_properties-fix-pk.sql:	SELECT * FROM /*_*/user_properties;

Event Timeline

Reedy created this task.May 10 2020, 1:13 AM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptMay 10 2020, 1:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 595312 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Use explicit column names in SQLite patch-site_identifiers-fix-pk.sql

https://gerrit.wikimedia.org/r/595312

Reedy updated the task description. (Show Details)May 10 2020, 1:15 AM
Reedy updated the task description. (Show Details)May 10 2020, 1:26 AM

Change 595312 merged by jenkins-bot:
[mediawiki/core@master] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/595312

Change 597151 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_34] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/597151

Change 597152 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_33] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/597152

Change 597155 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_31] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/597155

Change 597151 merged by jenkins-bot:
[mediawiki/core@REL1_34] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/597151

Change 597155 merged by jenkins-bot:
[mediawiki/core@REL1_31] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/597155

Change 597152 merged by jenkins-bot:
[mediawiki/core@REL1_33] Fixup some SELECT * usages in sqlite schema patches

https://gerrit.wikimedia.org/r/597152

CCicalese_WMF added a subscriber: CCicalese_WMF.

Untagging, since there is nothing to review right now. Feel free to re-tag if there's a new patch.