Dialogs: rejected setup or ready process results in uncaught exception
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	May 11 2020, 11:15 AM

Description

Returning a rejected promise from a setup or ready process is supposed to be an API for not opening the window.

Since https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/532746/ it has resulted in an uncaught exception, and the window manager closing promise not continuing.

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.39.1	mediawiki/core	master	+160 -65
	WindowManager: Only rethrow errors	oojs/ui	master	+12 -8

Change 595506 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] WindowManager: Only rethrow errors

Change 595506 merged by jenkins-bot:
[oojs/ui@master] WindowManager: Only rethrow errors

Change 602503 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.39.1

Change 602503 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.39.1

Volker_E closed this task as Resolved.Jun 4 2020, 11:03 PM

Volker_E triaged this task as Medium priority.

Volker_E moved this task from Next-up to OOUI-0.39.1 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.39.1); removed OOUI.