Page MenuHomePhabricator

Dialogs: rejected setup or ready process results in uncaught exception
Closed, ResolvedPublic

Description

Returning a rejected promise from a setup or ready process is supposed to be an API for not opening the window.

Since https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/532746/ it has resulted in an uncaught exception, and the window manager closing promise not continuing.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2020, 11:15 AM

Change 595506 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] WindowManager: Only rethrow errors

https://gerrit.wikimedia.org/r/595506

Change 595506 merged by jenkins-bot:
[oojs/ui@master] WindowManager: Only rethrow errors

https://gerrit.wikimedia.org/r/595506

matmarex moved this task from Backlog to Next-up on the OOUI board.May 11 2020, 5:12 PM

Change 602503 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.39.1

https://gerrit.wikimedia.org/r/602503

Change 602503 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.39.1

https://gerrit.wikimedia.org/r/602503

Volker_E closed this task as Resolved.Jun 4 2020, 11:03 PM
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Next-up to OOUI-0.39.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.39.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.