Call CompareService::getTotalEditsFromIp for each IP instead of each row
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	May 13 2020, 10:04 AM

Description

As discussed in T248588#6131426, this query need only be run once for each IP in compare check results. Instead it is currently being run once for each result row. Since rows can contain the same IP, that means it is being repeated unnecessarily.

Details

	Subject	Repo	Branch	Lines +/-
	Cache CompareService::getTotalEditsFromIp result in an array	mediawiki/extensions/CheckUser	master	+25 -25

Customize query in gerrit

Related Objects

Mentioned Here: rMW6c579760b733: Localisation updates from https://translatewiki.net.

Event Timeline

Tchanders created this task.May 13 2020, 10:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2020, 10:04 AM

• Niharika triaged this task as Medium priority.May 13 2020, 3:57 PM

• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

ARamirez_WMF set the point value for this task to 1.May 13 2020, 4:09 PM

ARamirez_WMF changed the point value for this task from 1 to 2.May 13 2020, 4:19 PM

• Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.May 13 2020, 5:54 PM

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.May 20 2020, 3:25 PM

• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

• Niharika edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).May 20 2020, 4:28 PM

• Niharika moved this task from Untriaged to Cards ready for development on the Anti-Harassment board.

dmaza claimed this task.Jun 11 2020, 4:07 AM

dmaza moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.

dmaza edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

dmaza moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 605395 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Cache CompareService::getTotalEditsFromIp result in an array

https://gerrit.wikimedia.org/r/605395

gerritbot added a project: Patch-For-Review.Jun 14 2020, 4:34 AM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jun 15 2020, 3:54 PM

Change 605395 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Cache CompareService::getTotalEditsFromIp result in an array

https://gerrit.wikimedia.org/r/605395

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 7:11 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 15 2020, 8:00 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jun 16 2020, 2:04 PM

I looked at the logs for a couple of different investigations.

Checked that for each IP in the Compare table there was one (and only one) call to getTotalEditsFromIp for that IP.

This true also when IPs have been filtered out (we don't make a call to getTotalEditsFromIp for filtered out IPs).

Test environment: vagrant MediaWiki 1.35.0-alpha (6c57976).

• Niharika closed this task as Resolved.Jul 27 2020, 6:06 PM

Call CompareService::getTotalEditsFromIp for each IP instead of each rowClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Call CompareService::getTotalEditsFromIp for each IP instead of each row
Closed, ResolvedPublic2 Estimated Story Points
Actions