Page MenuHomePhabricator

WikidataPageBanner should no longer use SkinTemplateOutputPageBeforeExec hook
Closed, ResolvedPublic

Description

WikidataPageBanner is run in production so this blocks the deprecation of SkinTemplateOutputPageBeforeExec

WikidataPageBanner sets prebodyhtml and manipulates the subtitle keys.

WikidataPageBanner per https://www.mediawiki.org/wiki/User:Jdlrobson/Skins_for_extension_developers#Modifying_subtitle should use the OutputPage methods clearSubtitle, getSubtitle, and addSubtitle to get the same effect instead of using the template key prebodyhtml which will soon not mean anything.

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 2 2020, 11:11 PM

Change 602142 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikidataPageBanner@master] Simplify wikidatabanner injection and restore banners to Vector

https://gerrit.wikimedia.org/r/602142

Change 602142 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Simplify wikidatabanner injection and restore banners to Vector

https://gerrit.wikimedia.org/r/602142

Jdlrobson closed this task as Resolved.Jun 4 2020, 11:11 PM
Jdlrobson claimed this task.

Will create a user notice shortly after the deploy that's happening right now.