Description

The cache is supposed to be updated whenever rebuildNodes is called, but it appears that rarely happens anymore, probable since the TreeModifier rewrite?

Context: https://lists.wikimedia.org/pipermail/wikitech-l/2020-June/093467.html

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (b7f83c6ba)	mediawiki/extensions/VisualEditor	master	+1 -1
	Update ve.dm.Document#nodesByType from TreeModifier	VisualEditor/VisualEditor	master	+146 -11

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDb7f83c6ba24e: Merge "Update ve.dm.Document#nodesByType from TreeModifier"

Event Timeline

• Esanders created this task.Jun 3 2020, 2:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2020, 2:08 PM

Change 602088 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Update ve.dm.Document#nodesByType from TreeModifier

https://gerrit.wikimedia.org/r/602088

gerritbot added a project: Patch-For-Review.Jun 3 2020, 2:22 PM

Change 602088 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update ve.dm.Document#nodesByType from TreeModifier

https://gerrit.wikimedia.org/r/602088

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2020, 10:10 PM

Change 602180 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b7f83c6ba)

https://gerrit.wikimedia.org/r/602180

gerritbot added a project: Patch-For-Review.Jun 3 2020, 10:18 PM

matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Jun 3 2020, 10:24 PM

matmarex moved this task from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.

matmarex added a project: Skipped QA.

matmarex updated the task description. (Show Details)

matmarex subscribed.

Change 602180 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b7f83c6ba)

https://gerrit.wikimedia.org/r/602180

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 3 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2020, 11:10 PM

ppelberg closed this task as Resolved.Jun 5 2020, 1:16 AM