Page MenuHomePhabricator

ve.dm.Document: nodesByType is no longer updated when the document is modified
Closed, ResolvedPublic

Description

The cache is supposed to be updated whenever rebuildNodes is called, but it appears that rarely happens anymore, probable since the TreeModifier rewrite?

Context: https://lists.wikimedia.org/pipermail/wikitech-l/2020-June/093467.html

Event Timeline

Esanders created this task.Jun 3 2020, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2020, 2:08 PM

Change 602088 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Update ve.dm.Document#nodesByType from TreeModifier

https://gerrit.wikimedia.org/r/602088

Change 602088 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update ve.dm.Document#nodesByType from TreeModifier

https://gerrit.wikimedia.org/r/602088

Change 602180 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b7f83c6ba)

https://gerrit.wikimedia.org/r/602180

Change 602180 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b7f83c6ba)

https://gerrit.wikimedia.org/r/602180

ppelberg closed this task as Resolved.Jun 5 2020, 1:16 AM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 5 2020, 1:16 AM