Page MenuHomePhabricator
Create Task
Maniphest T254868

Use version 2 of APIs in FileImporter
Closed, ResolvedPublic
Actions

Description

As of now, the FileImporter codebase uses mostly legacy API requests:

  • We don't set formatversion=2, which means version 1 is used by default. The legacy format is the one with these weird * "main content" fields. And it returns only 1 error and discards the rest.
  • We don't set errorformat=plaintext, which means the default bc is used.
  • We don't set rvslots=main in the revisions query.

Proof-of-concept patch: https://gerrit.wikimedia.org/r/603567

Acceptance criteria:

  • Update API parameters as above.
  • Log API warnings so we catch future deprecations.

Details

SubjectRepoBranchLines +/-
Update revision details requests to formatversion=2mediawiki/extensions/FileImportermaster+151 -77
Dedicated functions for revision detailsmediawiki/extensions/FileImportermaster+35 -17
Update error format for all API callsmediawiki/extensions/FileImportermaster+13 -0
Use formatversion=2 in ImportTitleChecker, remove unused elementsmediawiki/extensions/FileImportermaster+26 -22
Modernize API call querying a CSRF tokenmediawiki/extensions/FileImportermaster+7 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Jun 9 2020, 12:27 PM
gerritbot added a comment.Jun 12 2020, 1:13 PM

Change 605218 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Use formatversion=2 in ImportTitleChecker, remove unused elements

https://gerrit.wikimedia.org/r/605218

gerritbot added a project: Patch-For-Review.Jun 12 2020, 1:13 PM
gerritbot added a comment.Jun 12 2020, 3:40 PM

Change 605263 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Modernize API call querying a CSRF token

https://gerrit.wikimedia.org/r/605263

gerritbot added a comment.Jun 12 2020, 4:05 PM

Change 605263 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Modernize API call querying a CSRF token

https://gerrit.wikimedia.org/r/605263

thiemowmde mentioned this in rEFLI8c2e922f8ad7: Modernize API call querying a CSRF token.Jun 12 2020, 4:07 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 12 2020, 5:00 PM
gerritbot added a comment.Jun 15 2020, 10:04 AM

Change 605218 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Use formatversion=2 in ImportTitleChecker, remove unused elements

https://gerrit.wikimedia.org/r/605218

thiemowmde mentioned this in rEFLIb1fbe04db77b: Use formatversion=2 in ImportTitleChecker, remove unused elements.Jun 15 2020, 10:06 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 10:10 AM
awight added a comment.Jun 15 2020, 4:29 PM

Here's another action we could take: pass through any API warnings to the logger. This allows us to detect future deprecations, and would have caught the ones we're fixing now.

awight updated the task description. (Show Details)Jun 22 2020, 2:19 PM
awight moved this task from Proposed to Maintenance Backlog on the WMDE-TechWish board.Oct 30 2020, 1:31 PM
thiemowmde added a project: MediaWiki-extensions-Maintenance (by Skizzerz).Nov 3 2020, 9:40 AM
thiemowmde edited projects, added WMDE-TechWish-Maintenance; removed MediaWiki-extensions-Maintenance (by Skizzerz).Nov 3 2020, 11:28 AM
awight moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.Dec 7 2021, 2:33 PM
thiemowmde added a project: WMDE-TechWish-Maintenance-2023.Jun 7 2023, 12:44 PM
thiemowmde mentioned this in T338439: Update MediaWiki API calls in TechWish products to use formatversion=2.Jun 8 2023, 12:06 PM
thiemowmde added a parent task: T338439: Update MediaWiki API calls in TechWish products to use formatversion=2.
awight claimed this task.Jun 23 2023, 7:20 AM
awight moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.
gerritbot added a comment.Jun 23 2023, 7:55 AM

Change 932374 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/FileImporter@master] [WIP] Update the remaining API calls to newer version

https://gerrit.wikimedia.org/r/932374

gerritbot added a project: Patch-For-Review.Jun 23 2023, 7:55 AM
gerritbot added a comment.Jun 29 2023, 2:59 PM

Change 934344 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/FileImporter@master] Update error format for all API calls

https://gerrit.wikimedia.org/r/934344

gerritbot added a comment.Jun 29 2023, 2:59 PM

Change 934345 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/FileImporter@master] Dedicated functions for revision details

https://gerrit.wikimedia.org/r/934345

awight moved this task from Doing to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.Jun 30 2023, 8:14 AM
awight moved this task from Watching / Epic to Review on the WMDE-TechWish-Maintenance-2023 board.
awight removed awight as the assignee of this task.Jul 3 2023, 6:14 AM
thiemowmde added a subtask: T340004: FileImporter extension suite tests fail with UnexpectedValueException from FlaggedRevs.Jul 5 2023, 7:47 AM
thiemowmde closed subtask T340004: FileImporter extension suite tests fail with UnexpectedValueException from FlaggedRevs as Resolved.Jul 7 2023, 1:48 PM
gerritbot added a comment.Jul 17 2023, 7:58 PM

Change 934344 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Update error format for all API calls

https://gerrit.wikimedia.org/r/934344

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 17 2023, 8:00 PM
gerritbot added a comment.Aug 10 2023, 4:00 PM

Change 934345 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Dedicated functions for revision details

https://gerrit.wikimedia.org/r/934345

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Aug 10 2023, 5:00 PM
lilients_WMDE renamed this task from Stop using legacy APIs in FileImporter to Use version 2 of APIs in FileImporter.Sep 28 2023, 1:16 PM
awight moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.Oct 2 2023, 1:04 PM
gerritbot added a comment.Oct 2 2023, 1:17 PM

Change 932374 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Update revision details requests to formatversion=2

https://gerrit.wikimedia.org/r/932374

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 1:30 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.29; 2023-10-03); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Oct 2 2023, 2:00 PM
WMDE-Fisch closed this task as Resolved.Oct 18 2023, 1:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL