MathSearch CI jobs fail
Closed, ResolvedPublic
Actions

Description

As a Wikibase developer, I want to make changes in related extensions (in this case for T172368) and have CI tell me if I did something wrong or not.

Problem:
CI for MathSearch seems to be broken. I noticed this in my change Ia9165fc6dc, but it has apparently been broken for at least a week, since in I3445cd9266 two CI jobs also failed (quibble-vendor-mysql-php72-noselenium-docker, quibble-vendor-selenium-docker), and the change was then force-merged. (That said, the set of CI jobs seems to have changed since then. mwext-php72-phan-seccheck-docker, which had not failed back then, is now gone; on the other hand, mwext-php72-phan-docker now fails as well, when it had still succeeded in that change.)

Example:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MathSearch/+/604737#message-f62103042407955ec712ec04a0a3bfe0f40dcb4c
(I’ve marked the three failing builds to be kept forever.)

Details

	Subject	Repo	Branch	Lines +/-
	Remove uses of deprecated Revision methods	mediawiki/extensions/MathSearch	master	+37 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	DannyS712	T255154 MathSearch CI jobs fail
Resolved	Physikerwelt	T255937 Enable Phan for MW:MathSearch
Open	None	T255945 Fix phan warnings / errors in source files (includes)
Open	None	T255946 Fix phan warnings / errors in maintenance scripts

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 11 2020, 3:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2020, 3:10 PM

Lucas_Werkmeister_WMDE added a project: ci-test-error.Jun 12 2020, 10:20 AM

It is broken since https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MathSearch/+/603791/ was forcefully merged. I don't know why?

It was broken before then - if you see the explanation for the force merge, its because of the deprecations I've been making in T246284: Hard deprecate the Revision class - the extension needs to be updated to avoid using those deprecated methods.

Change 606813 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MathSearch@master] MathSearchHooks: Remove use of deprecated Revision methods

https://gerrit.wikimedia.org/r/606813

gerritbot added a project: Patch-For-Review.Jun 21 2020, 8:30 AM

DannyS712 claimed this task.Jun 21 2020, 8:33 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 21 2020, 8:33 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jun 21 2020, 8:34 AM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).