[1.36] Remove VectorBeforeFooter
Closed, ResolvedPublic
Actions

Description

The VectorBeforeFooter was marked as deprecated in 1.35. It should be removed in 1.36 (replaced with a more generic hook in core if needed).

There is one usage in ShoutAds so am interested in hearing from the maintainer about the use case.

https://codesearch.wmflabs.org/search/?q=VectorBeforeFooter&i=nope&files=&repos=

I'm pretty sure that SkinAfterContent with some CSS or AddFooterLink could be used to achieve the same effect. Please let me know :)

Acceptance criteria

Remove VectorFooter from the codebase (no need to add release notes as there is no process in place for skins)

Details

	Subject	Repo	Branch	Lines +/-
	Remove VectorBeforeFooter hook	mediawiki/skins/Vector	master	+2 -16

Customize query in gerrit

Related Objects

Mentioned Here: T2001: [DO NOT USE] Documentation is out of date, incomplete (tracking) [superseded by #Documentation]

Event Timeline

Jdlrobson created this task.Jun 11 2020, 10:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2020, 10:58 PM

Jdlrobson moved this task from Phase 1 - simplify hook contracts to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jun 11 2020, 10:58 PM

I'm pretty sure that SkinAfterContent with some CSS or AddFooterLink could be used to achieve the same effect.

Perhaps, I've got some changes to make to ShoutWikiAds at some point in the near future, I'll have to have a look. I'll note that it probably doesn't help that neither of said Hooks are listed at Manual:Hooks (*cough* T2001 *cough*)

Jdlrobson added projects: Web-Team-Backlog (Kanbanana-2019-20-Q4), MW-1.35-release.Jun 12 2020, 11:52 PM

Here you go:
https://www.mediawiki.org/wiki/Manual:Hooks/SkinAfterContent
https://www.mediawiki.org/wiki/Manual:Hooks/SkinAddFooterLinks

Let me know if you have any questions!

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.Jun 15 2020, 9:55 PM

Jdlrobson renamed this task from Deprecate VectorBeforeFooter hook to [1.36] Remove VectorBeforeFooter.Jun 15 2020, 9:59 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-2019-20-Q4).

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Phase 1 - simplify hook contracts to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jun 15 2020, 11:52 PM

@Jdlrobson The title says 1.36, but MW-1.35-release is also tagged.

Jdlrobson removed a project: MW-1.35-release.Jun 21 2020, 5:09 PM

Jdlrobson added a project: MW-1.36-release.

DannyS712 moved this task from Blocker to To deprecate or remove on the MW-1.36-release board.Jun 26 2020, 10:50 PM

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jun 29 2020, 11:32 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 8 2020, 12:08 AM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Jul 24 2020, 5:25 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: Peter.ovchyn.

Jdlrobson triaged this task as High priority.Jul 24 2020, 5:28 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 616188 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Remove VectorBeforeFooter hook

https://gerrit.wikimedia.org/r/616188

gerritbot added a project: Patch-For-Review.Jul 25 2020, 1:39 AM

Ammarpad claimed this task.Jul 25 2020, 1:48 AM

Jdlrobson removed a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Jul 28 2020, 5:45 PM

Change 616188 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove VectorBeforeFooter hook

https://gerrit.wikimedia.org/r/616188

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 13 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2020, 11:10 PM

Jdlrobson updated the task description. (Show Details)Aug 13 2020, 11:32 PM

Jdlrobson removed a project: ShoutWiki.

Jdlrobson closed this task as Resolved.Aug 16 2020, 4:25 PM

[1.36] Remove VectorBeforeFooterClosed, ResolvedPublicActions