Create some sort of box with the box-shadow values applied.
Maybe something with a light color background which pops on the white background thanks to the shadow.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Sarai-WMDE | T255423 See and use design tokens to define specs for handover | |||
| Resolved | darthmon_wmde | T256024 Illustrate tokens | |||
| Resolved | • Tonina_Zhelyazkova_WMDE | T256858 Create visalization for shadows |
Event Timeline
Comment Actions
Improvement suggestions:
- The 2 global tokens (box-shadow-inset-thin, box-shadow-inset-thick) should go on top
- The font size of the text in the duration value column (<pre>) should be 14px.
- The value text should be outside the specimen
- The speciment should be smaller (suggestion: 32px in height)
- The bg color of the specimens (#ffe599) does not help visualizing the inset. I'd suggest using a gray (e.g. #c8ccd1).
Comment Actions
https://github.com/wmde/wikit/pull/58
FYI: The first point is not addressed, because it spiraled a bigger discussion. The outcome of which is https://phabricator.wikimedia.org/T257065
Comment Actions
@Sarai-WMDE your new favorite rectangles are ready to be reviewed -> https://wmde.github.io/wikit/?path=/docs/design-tokens-shadows--page
Comment Actions
those are indeed some lovely rectangles. looking good! ready to move to done imo (not sure if you need to wait for code review)